-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show error message if backing up credential file fails #2517
Conversation
Fantastic point. Let me get that messaging tweaked, and I'll request a re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existing code looks great, but as mentioned in my verification note, we should update the error message to indicate that the user's credentials are corrupt and provide some action path for them to resolve.
Currently:
Failed to backup credentials to /Users/billsager/.connect-credentials-2025-01-09: open /Users/billsager/.connect-credentials: permission denied
Perhaps:
Corrupted credentials data found. Failed to resolve this issue by backing up credentials to /Users/billsager/.connect-credentials-2025-01-09: open /Users/billsager/.connect-credentials: permission denied" prior to resetting.
(Just a start ^^^)
Pushed up a change. Now the error will read:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds a new
AgentError
that bubbles up if operations in the backing-up of the credential file fail, showing the user the message so they may take action on it.Intent
Resolves #2513
Type of Change
User Impact
Now a notification will be shown with the specific error that occurred when backing up a credential file, with an error code that we can do more with in the future.
Automated Tests
Automated tests were added to ensure that the correct data is sent back when the reset API errors.
Directions for Reviewers
Ensure that the error bubbles up via the API, is shown as a notification, and works in Workbench.