fix: Disable validation without making check.disable()
async
#10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
Closes #9
The issue in #8 arises because
InputValidator.disable()
calls the asyncsession.send_custom_message()
without awaiting.One option would be to declare the
.disable()
method async, but this would be a breaking change in the sense that app authors would need to update their apps to mark any callers of.disable()
asasync
and thenawait
thedisable
call.I don't think this is worth the collective effort; instead we can simply fire off the disabling message, which only affects UI elements in the app. This PR does exactly that: we fire-and-forget the custom message, leaving
.disable()
"synchronous".Example app