New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression processor: Results & Error Handling #2027

Merged

chriseth merged 16 commits into powdr-labs:main from gzanitti:expr_proc_results

Nov 14, 2024

Collaborator

gzanitti commented Nov 4, 2024

No description provided.

gzanitti added 6 commits

November 4, 2024 12:27

WIP

58ff57b


          results without error msgs

7296ce3


          basic msgs

333d9ca


          untyped

c41d065


          msgs

7b81b8a


          error msg

07f6029

gzanitti marked this pull request as ready for review

November 4, 2024 23:06

gzanitti commented

View reviewed changes

pil-analyzer/src/untyped_evaluator.rs Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

pil-analyzer/src/expression_processor.rs Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

pil-analyzer/src/expression_processor.rs Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

pil-analyzer/src/expression_processor.rs Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

pil-analyzer/src/expression_processor.rs Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

pil-analyzer/src/pil_analyzer.rs Show resolved Hide resolved

chriseth reviewed

View reviewed changes

pil-analyzer/src/statement_processor.rs Show resolved Hide resolved

chriseth reviewed

View reviewed changes

pil-analyzer/tests/types.rs Show resolved Hide resolved

gzanitti and others added 6 commits

November 6, 2024 12:21


          general improvements

ac43efe


          Update pil-analyzer/src/pil_analyzer.rs

614001f

Co-authored-by: chriseth <[email protected]>


          Update pil-analyzer/src/statement_processor.rs

8fbbf03

Co-authored-by: chriseth <[email protected]>


          Merge branch 'expr_proc_results' of https://github.com/gzanitti/powdr …

4d8dc1e

…into expr_proc_results


          Code org & error handling

66c53c5


          fix mutability

38f9484

Member

chriseth commented Nov 7, 2024

Looks good! The only comment left is the updated test expectation. Is it just a temporary change?

The untyped evaluator can be done in its own PR.


          fix error

04b2f8d

Member

chriseth commented Nov 13, 2024

Did you check if the escaping issue is a real issue (by running the commandline interface) or just a testing issue?

gzanitti added 3 commits

November 13, 2024 10:25


          Merge remote-tracking branch 'upstream/main' into expr_proc_results

c2a6e16


          rollback msg

c84b533


          fix error msg

f70fae8

Collaborator Author

gzanitti commented Nov 13, 2024 •

edited

Loading

Did you check if the escaping issue is a real issue (by running the commandline interface) or just a testing issue?

Oh, yes, the three lines only occur when parsing the error during testing. When running the command line interface, the error is the same as the one that is created in the message

chriseth approved these changes

View reviewed changes

chriseth enabled auto-merge

November 13, 2024 15:26

chriseth added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks

chriseth added this pull request to the merge queue

Merged via the queue into powdr-labs:main with commit 49c1eed

14 checks passed

gzanitti deleted the expr_proc_results branch

December 6, 2024 18:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet