Improve constant evaluation logging #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
force-pushed
the
improve-constant-evaluation-logging
branch
from
9ee4850 to
e5ec7b5
Compare
leonardoalt
approved these changes
Nov 13, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
After analyzing what is taking such a long time when evaluating fixed column (#2083), I noticed that the Poseidon machine uses the default degree range, independent of the `--max-degree-log` degree log. I set it to `LARGE_SUBMACHINES_MAX_DEGREE` instead, which means that it is 4x larger than the main machine. Given a block size of 31, that means that it has enough rows if at most 1 / 8 (=12.5%) of the CPU instructions are calls to Poseidon, which should be enough? For `--max-degree-log 18`, this reduces the time to evaluate constant columns from 109s to 33s.
Schaeff
pushed a commit
that referenced
this pull request
Nov 14, 2024
After analyzing what is taking such a long time when evaluating fixed column (#2083), I noticed that the Poseidon machine uses the default degree range, independent of the `--max-degree-log` degree log. I set it to `LARGE_SUBMACHINES_MAX_DEGREE` instead, which means that it is 4x larger than the main machine. Given a block size of 31, that means that it has enough rows if at most 1 / 8 (=12.5%) of the CPU instructions are calls to Poseidon, which should be enough? For `--max-degree-log 18`, this reduces the time to evaluate constant columns from 109s to 33s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that constant evaluation takes a very long time. With this logging, it is easier to see why, e.g. for the Rust Keccak example: