Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-powdr gitignore add on template #2213

Merged
merged 1 commit into from
Dec 11, 2024
Merged

cargo-powdr gitignore add on template #2213

merged 1 commit into from
Dec 11, 2024

Conversation

MuhtasimTanmoy
Copy link
Contributor

@MuhtasimTanmoy
Copy link
Contributor Author

Should extend to https://github.com/github/gitignore/blob/main/Rust.gitignore ?

@leonardoalt
Copy link
Member

Thanks! I don't think we should add the Rust one for now, but we could at least add Cargo.lock for both host and guest.

@leonardoalt
Copy link
Member

Also, we recently fixed something in main, can you please merge main into your branch

@MuhtasimTanmoy
Copy link
Contributor Author

we could at least add Cargo.lock for both host and guest.

What about powdr-target?

@MuhtasimTanmoy MuhtasimTanmoy force-pushed the cargo-powdr-gitignore-add-on-template branch from 861fab6 to 7ad02b3 Compare December 10, 2024 19:33
@MuhtasimTanmoy
Copy link
Contributor Author

Can you please merge main into your branch.

Rebased.

Please check.

@leonardoalt
Copy link
Member

What about powdr-target?

yea let's do that one too

@MuhtasimTanmoy
Copy link
Contributor Author

@leonardoalt Already done.

leonardoalt
leonardoalt approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@leonardoalt leonardoalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@leonardoalt leonardoalt added this pull request to the merge queue Dec 11, 2024
Merged via the queue into powdr-labs:main with commit 56d43c4 Dec 11, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardoalt leonardoalt leonardoalt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MuhtasimTanmoy @leonardoalt