Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pilopt: equal-constrained witness columns removal #2224

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

pilopt: equal-constrained witness columns removal #2224

wants to merge 13 commits into from
+286 −78

Conversation

gzanitti
Copy link
Collaborator

@gzanitti gzanitti commented Dec 11, 2024 •
edited
Loading

Resolves #2081

@gzanitti gzanitti mentioned this pull request Dec 11, 2024
Closed
@gzanitti gzanitti marked this pull request as ready for review December 11, 2024 15:50
chriseth
chriseth reviewed Dec 12, 2024
View reviewed changes
pilopt/src/lib.rs Outdated Show resolved Hide resolved
chriseth
chriseth reviewed Dec 12, 2024
View reviewed changes
pilopt/src/lib.rs Outdated Show resolved Hide resolved
chriseth
chriseth reviewed Dec 12, 2024
View reviewed changes
pilopt/src/lib.rs Outdated Show resolved Hide resolved
chriseth
chriseth reviewed Dec 12, 2024
View reviewed changes
pilopt/src/lib.rs Outdated Show resolved Hide resolved
chriseth
chriseth reviewed Dec 12, 2024
View reviewed changes
pilopt/src/lib.rs Outdated Show resolved Hide resolved
chriseth
chriseth reviewed Dec 12, 2024
View reviewed changes
pilopt/tests/optimizer.rs Outdated Show resolved Hide resolved
@gzanitti gzanitti requested a review from chriseth December 20, 2024 02:45
Schaeff
Schaeff reviewed Jan 8, 2025
View reviewed changes
pilopt/src/lib.rs Outdated Show resolved Hide resolved
Schaeff
Schaeff reviewed Jan 8, 2025
View reviewed changes
pilopt/src/lib.rs Outdated Show resolved Hide resolved
Schaeff
Schaeff reviewed Jan 8, 2025
View reviewed changes
pilopt/src/lib.rs Outdated Show resolved Hide resolved
Schaeff
Schaeff reviewed Jan 8, 2025
View reviewed changes
pilopt/src/lib.rs Outdated Show resolved Hide resolved
@gzanitti gzanitti requested a review from Schaeff January 9, 2025 18:44
Schaeff
Schaeff previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@Schaeff Schaeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe @pacheco wants to have a look at the riscv executor

pacheco
pacheco reviewed Jan 15, 2025
View reviewed changes
riscv-executor/src/lib.rs Outdated Show resolved Hide resolved
pacheco
pacheco approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@pacheco pacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacheco pacheco pacheco approved these changes

@Schaeff Schaeff Schaeff left review comments

@chriseth chriseth Awaiting requested review from chriseth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimizer should remove equal-constrained witness columns.
4 participants
@gzanitti @pacheco @Schaeff @chriseth