add an ExecMode::Witness to the riscv executor #2333
+121
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExecMode::Trace should only produce the memory and registers trace
leonardoalt
reviewed
Jan 15, 2025
riscv-executor/src/lib.rs
Outdated
| @@ -2854,6 +2877,7 @@ pub fn execute<F: FieldElement>( | |||
| prover_ctx: &Callback<F>, | |||
| bootloader_inputs: &[F], | |||
| max_steps_to_execute: Option<usize>, | |||
| full_witness: bool, | |||
There was a problem hiding this comment.
Shouldn't this just be ExecMode?
There was a problem hiding this comment.
but then you could also pass Fast, which is invalid
There was a problem hiding this comment.
exec mode is internal to the crate
There was a problem hiding this comment.
yea, just don't really like bool parameters..but ok
leonardoalt
previously approved these changes
Jan 16, 2025
Any commits made after this event will not be merged.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
leonardoalt
approved these changes
Jan 16, 2025
Any commits made after this event will not be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecMode::Trace should only produce the memory and registers trace