Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small field arith machine for bus linker mode #2339

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

georgwiese
Copy link
Collaborator

@georgwiese georgwiese commented Jan 14, 2025

Same change as #2297. I opened #2340 to track fixing the root cause.

With this change, we can have the BabyBear RISC-V machine with a bus:

cargo run -r --features plonky3 --bin powdr-rs compile riscv/tests/riscv_data/keccak-o output --field bb
cargo run -r --features plonky3 pil output/keccak.asm -o output -f --field bb --prove-with plonky3 --linker-mode bus

@georgwiese georgwiese marked this pull request as ready for review January 14, 2025 20:45
@georgwiese georgwiese marked this pull request as draft January 14, 2025 21:41
@leonardoalt
Copy link
Member

witgen doesn't like it

@georgwiese
Copy link
Collaborator Author

Oh wow, it was actually a copy-paste error (the range check went to byte2 instead of byte). Fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants