Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluaton of fixed columns that are constant outside the first and last row. #2346

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

chriseth
Copy link
Member

@chriseth chriseth commented Jan 15, 2025

Allows fixed columns to be evaluated in the "single step jit processor" by pre-computing if a fixed column has a constant value apart from the first and last row.

@chriseth chriseth force-pushed the fixed_eval_on_nonzero_row branch 2 times, most recently from 38fb517 to 3d8e903 Compare January 15, 2025 18:20
@chriseth chriseth force-pushed the fixed_eval_on_nonzero_row branch from 3d8e903 to 656c396 Compare January 15, 2025 18:22
georgwiese
georgwiese previously approved these changes Jan 15, 2025
Copy link
Collaborator

@georgwiese georgwiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Needs merge though.

@georgwiese georgwiese added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 95dcf38 Jan 16, 2025
16 checks passed
@georgwiese georgwiese deleted the fixed_eval_on_nonzero_row branch January 16, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants