Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional latch and operation_id #594

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Optional latch and operation_id #594

merged 1 commit into from
Oct 24, 2023

Conversation

Schaeff
Copy link
Collaborator

@Schaeff Schaeff commented Sep 12, 2023

closes #576 and #577

@Schaeff Schaeff force-pushed the optional-latch-and-operation-id branch 2 times, most recently from 89ef45b to fd6b6a6 Compare September 13, 2023 15:57
georgwiese
georgwiese reviewed Oct 4, 2023
View reviewed changes
linker/src/lib.rs Show resolved Hide resolved
linker/src/lib.rs Show resolved Hide resolved
analysis/src/block_enforcer.rs Show resolved Hide resolved
@Schaeff Schaeff force-pushed the optional-latch-and-operation-id branch from fd6b6a6 to 8db466b Compare October 5, 2023 09:47
@Schaeff Schaeff requested a review from georgwiese October 12, 2023 22:09
georgwiese
georgwiese reviewed Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@georgwiese georgwiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But needs to be rebased.

compiler/tests/asm.rs Show resolved Hide resolved
compiler/tests/asm.rs Show resolved Hide resolved
@Schaeff Schaeff force-pushed the optional-latch-and-operation-id branch 2 times, most recently from af7ab72 to 41f151c Compare October 22, 2023 06:59
@Schaeff Schaeff force-pushed the optional-latch-and-operation-id branch from 41f151c to f71cd82 Compare October 22, 2023 07:34
@Schaeff Schaeff requested a review from georgwiese October 22, 2023 08:00
@Schaeff Schaeff enabled auto-merge October 22, 2023 08:00
georgwiese
georgwiese approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@georgwiese georgwiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Schaeff Schaeff added this pull request to the merge queue Oct 24, 2023
Merged via the queue into main with commit a58b5af Oct 24, 2023
2 checks passed
@Schaeff Schaeff deleted the optional-latch-and-operation-id branch October 24, 2023 15:27
@georgwiese georgwiese mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgwiese georgwiese georgwiese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Require operation_id only if a machine has many operations
2 participants
@Schaeff @georgwiese