Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve EVM test #739

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Improve EVM test #739

merged 3 commits into from
Nov 2, 2023

Conversation

leonardoalt
Copy link
Member

This PR:

  • fixes the EVM test by executing the tx after setting it up
  • changes the EVM test to receive the program's bytecode via prover input instead of hardcoded
  • removes degree statements from std machines
  • changes the riscv compiler to auto detect the degree needed by the program

georgwiese
georgwiese reviewed Nov 1, 2023
View reviewed changes
riscv/tests/riscv_data/evm/src/lib.rs Show resolved Hide resolved
riscv/src/compiler.rs Outdated Show resolved Hide resolved
riscv/src/compiler.rs Show resolved Hide resolved
georgwiese
georgwiese previously approved these changes Nov 1, 2023
View reviewed changes
riscv/src/compiler.rs Outdated Show resolved Hide resolved
chriseth
chriseth previously approved these changes Nov 2, 2023
View reviewed changes
@leonardoalt
Copy link
Member Author

Actually had to comment out the test again otherwise the tests are gonna fail, because the compiler and witgen need too much RAM to run this test.

@leonardoalt leonardoalt enabled auto-merge November 2, 2023 09:51
@leonardoalt leonardoalt added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit e70b9b7 Nov 2, 2023
2 checks passed
@leonardoalt leonardoalt deleted the evm-test branch November 2, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgwiese georgwiese georgwiese approved these changes

@chriseth chriseth chriseth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leonardoalt @georgwiese @chriseth