Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1782] Link Kit Target Prop #4195

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

gabbymassaro
Copy link
Contributor

@gabbymassaro gabbymassaro commented Jan 29, 2025

What does this PR do? A clear and concise description with your runway ticket url.
Add the 'target' prop to the link kit.
Create a new doc example for Rails and React for New Tab and New Window usage.

Screenshots: Screenshots to visualize your addition/change
Screenshot 2025-01-30 at 11 59 46 AM
Screenshot 2025-01-30 at 11 59 29 AM

How to test? Steps to confirm the desired behavior:

  1. Go to /kits/link/rails and /kits/link/react
  2. Scroll down to the new Target doc example
  3. See above changes

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@gabbymassaro gabbymassaro self-assigned this Jan 29, 2025
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1782-link-kit-target-prop

@gabbymassaro gabbymassaro added minor Semver Target enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels Jan 30, 2025
@gabbymassaro gabbymassaro marked this pull request as ready for review January 30, 2025 17:03
@gabbymassaro gabbymassaro requested a review from a team as a code owner January 30, 2025 17:03
@gabbymassaro gabbymassaro added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Jan 30, 2025
@jasperfurniss jasperfurniss added the Code Approved Approved by a Playbook Admin label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants