Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datasource][Resource]Add Network Interface and NSG Href To Instance Network #179

Closed
wants to merge 1 commit into from
Closed

[Datasource][Resource]Add Network Interface and NSG Href To Instance Network #179

wants to merge 1 commit into from

Conversation

michaelkad
Copy link
Collaborator

@michaelkad michaelkad commented Nov 13, 2024 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN TestAccIBMPIInstancesDataSource_basic
--- PASS: TestAccIBMPIInstancesDataSource_basic (54.74s)
PASS

=== RUN TestAccIBMPIInstanceDataSource_basic
--- PASS: TestAccIBMPIInstanceDataSource_basic (62.20s)
PASS

=== RUN TestAccIBMPIInstanceIPDataSource_basic
--- PASS: TestAccIBMPIInstanceIPDataSource_basic (55.81s)
PASS

=== RUN TestAccIBMPIInstanceNetworkSecurityGroup
--- PASS: TestAccIBMPIInstanceNetworkSecurityGroup (1048.98s)
PASS

@ismirlia
Copy link
Collaborator

@michaelkad I think this one is missing adding NSG id to instance creation under the PVMInstanceAddNetwork model.

@michaelkad michaelkad force-pushed the pvm-instance-ip-nsg branch 2 times, most recently from 90b9dd4 to 4633210 Compare February 11, 2025 17:27
@michaelkad michaelkad marked this pull request as ready for review February 11, 2025 17:28
@michaelkad
Copy link
Collaborator Author 

=== RUN TestAccIBMPIInstanceIPDataSource_basic
--- PASS: TestAccIBMPIInstanceIPDataSource_basic (34.52s)
PASS

=== RUN TestAccIBMPIInstanceDataSource_basic
--- PASS: TestAccIBMPIInstanceDataSource_basic (32.36s)
PASS

=== RUN TestAccIBMPIInstancesDataSource_basic
--- PASS: TestAccIBMPIInstancesDataSource_basic (46.13s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupRuleTCP
--- PASS: TestAccIBMPIInstanceNetworkSecurityGroup (1606.67s)
PASS

@michaelkad michaelkad changed the title Add Network Interface and NSG Href To Instance Network [Datasource][Resource]Add Network Interface and NSG Href To Instance Network Feb 12, 2025
@michaelkad
Add Network Interface and NSG Href To Instance Network
caf39f3 
update change with new sdk version

update change with new sdk version

Update text for nsg ids attr

remove duplicate line

Update sdk

Remove deprecated attr
@michaelkad michaelkad requested a review from ismirlia February 12, 2025 22:38
@michaelkad
Copy link
Collaborator Author

open in main repo

@michaelkad michaelkad closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismirlia ismirlia ismirlia approved these changes

@Alexander-Kita Alexander-Kita Awaiting requested review from Alexander-Kita

Assignees
No one assigned
Labels
Feature Q1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelkad @ismirlia @Alexander-Kita