Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datasource][Resource] Add dedicated host id to instance #194

Closed
wants to merge 3 commits into from
Closed

[Datasource][Resource] Add dedicated host id to instance #194

wants to merge 3 commits into from

Conversation

ismirlia
Copy link
Collaborator

@ismirlia ismirlia commented Jan 27, 2025 •
edited
Loading

Output for acceptance tests:

data source instance

--- PASS: TestAccIBMPIInstanceDataSource_basic (22.52s)
PASS

data source instances

--- PASS: TestAccIBMPIInstancesDataSource_basic (23.48s)
PASS

resource instances

--- PASS: TestAccIBMPIInstanceBasic (927.38s)
PASS

--- PASS: TestAccIBMPIInstanceIBMiLicense (937.23s)
PASS

--- PASS: TestAccIBMPIInstanceNetwork (754.88s)
PASS

--- PASS: TestAccIBMPISAPInstance (1093.12s)
PASS

--- PASS: TestAccIBMPIInstanceStorageConnection (480.87s)
PASS

@ismirlia ismirlia changed the title [Data source][Resource] Add dedicated host id to instance [Datasource][Resource] Add dedicated host id to instance Jan 27, 2025
@ismirlia
Copy link
Collaborator Author

I reordered the functions in resource_ibm_pi_instance_test.go such that the configurations are right under the tests that use them.

@ismirlia ismirlia force-pushed the ins-dedicated-host-id branch from cf6102c to 5579893 Compare January 31, 2025 17:36
michaelkad
michaelkad previously approved these changes Feb 3, 2025
View reviewed changes
@ismirlia ismirlia force-pushed the ins-dedicated-host-id branch from 5579893 to 1c4d0ae Compare February 6, 2025 15:08
@ismirlia ismirlia requested a review from michaelkad February 12, 2025 16:36
@ismirlia ismirlia force-pushed the ins-dedicated-host-id branch from 1c4d0ae to b521a93 Compare February 12, 2025 16:40
@ismirlia
Copy link
Collaborator Author

Opened IBM-Cloud#5995, closing this one

@ismirlia ismirlia closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexander-Kita Alexander-Kita Awaiting requested review from Alexander-Kita

@michaelkad michaelkad Awaiting requested review from michaelkad

Assignees
No one assigned
Labels
Feature Q1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismirlia @michaelkad