-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use XML::Hash::XS #366
base: xml2hash
Are you sure you want to change the base?
Use XML::Hash::XS #366
Conversation
So, in this first iteration, we learn that |
@pplu, with this change, test suite passes on my machine (minus some failure on 01_load.t, but same happens on the base branch, and I hope is unrelated). Let me know if there is anything else we need to do. Thanks! |
Looks like we should look at merging this for 0.44 (before 0.45), see #372 |
Hmm might clean up the issue I had with a few of the S3 actions where the parsing the XML beheaded it and I had to add in a little extra logic to handle the missing root key. Would have to look at my notes to see which one. |
There are a few responses that don't contain the main XML key (there's code in RestXMLResponse to handle it) - would be handy to get rid of XML::Simple regardless |
@pplu , this PR just merges into your |
Or, should we maybe change the target to be the next release branch to see how it behaves? |
working into xml2hash seems sane to me, I hadnt seen it was against that one |
Would love to see this stop-gap make it into a release. |
This makes
t/10_responses.t
pass