Fix setting null profile extras order

ppy · Jan 23, 2025 · 37c4d11 · 37c4d11
1 parent 83e7f98
commit 37c4d11
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/app/Models/UserProfileCustomization.php b/app/Models/UserProfileCustomization.php
@@ -85,7 +85,7 @@ public static function forUser(?User $user): array|static
         return $ret;
     }
 
-    public static function repairExtrasOrder($value)
+    public static function repairExtrasOrder(array $value): array
     {
         // read from inside out
         return array_values(
@@ -316,7 +316,10 @@ public function getExtrasOrderAttribute($value)
     public function setExtrasOrderAttribute($value)
     {
         $this->attributes['extras_order'] = null;
-        $this->setOption('extras_order', static::repairExtrasOrder($value));
+        $this->setOption(
+            'extras_order',
+            $value === null ? null : static::repairExtrasOrder($value),
+        );
     }
 
     public function getProfileCoverExpandedAttribute()