Merge pull request #11834 from TPGPL/pack-author-i18n

Add missing localisation to beatmap pack listing
ppy · Feb 5, 2025 · c09e8b9 · c09e8b9
2 parents 03a6365 + b7188dc
commit c09e8b9
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 10 deletions.
diff --git a/resources/css/bem/beatmap-pack.less b/resources/css/bem/beatmap-pack.less
@@ -15,12 +15,6 @@
     z-index: 1;
   }
 
-  &__author {
-    &--bold {
-      font-weight: 600;
-    }
-  }
-
   &__body {
     background-color: @osu-colour-b3;
   }

diff --git a/resources/lang/en/beatmappacks.php b/resources/lang/en/beatmappacks.php
@@ -17,6 +17,7 @@
     ],
 
     'show' => [
+        'created_by' => 'by :author',
         'download' => 'Download',
         'item' => [
             'cleared' => 'cleared',

diff --git a/resources/views/packs/index.blade.php b/resources/views/packs/index.blade.php
@@ -27,8 +27,7 @@
                         <div class="beatmap-pack__name">{{ $pack->name }}</div>
                         <div class="beatmap-pack__details">
                             <span class="beatmap-pack__date">{{ json_date($pack->date) }}</span>
-                            <span class="beatmap-pack__author">by </span>
-                            <span class="beatmap-pack__author beatmap-pack__author--bold">{{ $pack->author }}</span>
+                            <span>{!! osu_trans('beatmappacks.show.created_by', ['author' => tag('strong', content: e($pack->author))]) !!}</span>
                         </div>
                     </a>
                     <div class="beatmap-pack__body js-accordion__item-body"></div>

diff --git a/resources/views/packs/show.blade.php b/resources/views/packs/show.blade.php
@@ -14,8 +14,7 @@
                     <div class="beatmap-pack__name">{{ $pack->name }}</div>
                     <div class="beatmap-pack__details">
                         <span class="beatmap-pack__date">{{ json_date($pack->date) }}</span>
-                        <span class="beatmap-pack__author">by </span>
-                        <span class="beatmap-pack__author beatmap-pack__author--bold">{{ $pack->author }}</span>
+                        <span>{!! osu_trans('beatmappacks.show.created_by', ['author' => tag('strong', content: e($pack->author))]) !!}</span>
                     </div>
                 </a>