Team member leaderboard #11827
Merged
Team member leaderboard #11827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I feel like the leaderboard should be its own tab; the members section in the middle being variable height based on the window height seems like a weird behavior now... 🤔 |
|
might as well move members listing to where leaderboard currently is if we're moving the leaderboard to its own page...? |
|
drafting this to move to its own tab (and thus depend on #11837) |
nanaya
force-pushed
the
team-leaderboard
branch
2 times, most recently
from
0f80718 to
5c7db77
Compare
nanaya
force-pushed
the
team-leaderboard
branch
from
5c7db77 to
e9281a6
Compare
notbakaneko
requested changes
Feb 14, 2025
| } | ||
| $leaderboard = $team | ||
| ->members | ||
| ->loadMissing("user.{$statisticsRelationName}") |
There was a problem hiding this comment.
also need to load/set the team and userGroups
There was a problem hiding this comment.
more like too much copypaste 👀
notbakaneko
requested changes
Feb 14, 2025
notbakaneko
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is pretty close to the design?
Added a lone
infolink in the header to put the ruleset selector on (mainly for mobile). Will add link to member listing and settings page for admin later (and then remove the "back" link in respective pages).depends on