Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add team creation page #11835

Merged
merged 29 commits into from
Feb 19, 2025
Merged

Add team creation page #11835

merged 29 commits into from
Feb 19, 2025
+442 −32

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Feb 3, 2025 •
edited by notbakaneko
Loading

@nanaya nanaya marked this pull request as draft February 3, 2025 13:35
@nanaya nanaya marked this pull request as ready for review February 14, 2025 06:19
notbakaneko
notbakaneko requested changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts 👀

notbakaneko
notbakaneko requested changes Feb 17, 2025
View reviewed changes
resources/lang/en/model_validation.php Outdated Show resolved Hide resolved
resources/views/teams/create.blade.php Outdated Show resolved Hide resolved
app/Http/Controllers/TeamsController.php Outdated Show resolved Hide resolved
app/Http/Controllers/TeamsController.php Outdated Show resolved Hide resolved
app/Models/Team.php Show resolved Hide resolved
notbakaneko
notbakaneko requested changes Feb 18, 2025
View reviewed changes
app/Singletons/OsuAuthorize.php Outdated Show resolved Hide resolved
app/Http/Controllers/TeamsController.php Outdated Show resolved Hide resolved
app/Http/Controllers/TeamsController.php Outdated Show resolved Hide resolved
notbakaneko
notbakaneko previously approved these changes Feb 19, 2025
View reviewed changes
@notbakaneko notbakaneko disabled auto-merge February 19, 2025 04:56
notbakaneko
notbakaneko requested changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should tell you before you press the button that supporter is required 👀

@notbakaneko notbakaneko merged commit 551a11a into ppy:master Feb 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notbakaneko notbakaneko notbakaneko approved these changes

Assignees
No one assigned
Labels
area:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanaya @notbakaneko