Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hidden cursor state flag on non-desktop platforms as well #31226

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Dec 21, 2024

This makes the "high precision mouse" setting effective on iPadOS, however, raw mouse input is completely broke on iPadOS similar to macOS. The default value of the setting should be changed to false on such platforms anyway (ppy/osu-framework#6469).

This hides the little iPad system cursor that is shown along the menu cursor.

@peppy
Copy link
Member

peppy commented Dec 23, 2024

This makes the "high precision mouse" setting effective on iPadOS, however, raw mouse input is completely broke on iPadOS similar to macOS

I don't understand what you are saying here ("effective" in what way?), can you try rewording?

@frenzibyte
Copy link
Member Author

frenzibyte commented Dec 23, 2024

osu! on iPad always had support for raw mouse input (since we switched to SDL3 at least), we just didn't add the CursorState.Hidden flag so it was being disabled internally in o!f's MouseHandler implementation.

Of course this is before I realise it's still broken support, not working support. However, it's still a good change to make to hide the system cursor etc.

Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a try.

@peppy peppy merged commit df3b300 into ppy:master Dec 24, 2024
8 of 10 checks passed
@frenzibyte frenzibyte deleted the fix-raw-input-mobile branch December 24, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS/iPadOS native cursor overlaps with the in-game cursor
2 participants