Add ability to download beatmaps from context menu of beatmap cards #31468
Conversation
| @@ -24,6 +25,8 @@ public abstract partial class BeatmapCard : OsuClickableContainer, IHasContextMe | |||
|
|
|||
| protected const float WIDTH = 345; | |||
|
|
|||
| public CollapsibleButtonContainer ButtonContainer { get; set; } = null!; | |||
There was a problem hiding this comment.
I really really dislike this. This is how multiplayer ended up in the place it currently is, where random things are exposed for the purpose of inheriting screens setting them that eventually goes completely out of control.
Let's not make the same mistake again.
There was a problem hiding this comment.
I agree it's not 100% optimal, but also can't read your mind 😅.
I also tried an Action RequestDownload kinda flow but it felt way too verbose for what this is. Would that work better?
What's your preference?
There was a problem hiding this comment.
@smoogipoo prod on this one, need some direction before attempting something else that doesn't work for you.
There was a problem hiding this comment.
Sorry, I thought your reply was in response to the comment below.
Here's two suggestions:
- Make
ContextMenuItemsvirtual and duplicate the implementation. - Add abstract
DownloadButton? GetDownloadButton()and implement in every place.
| var menuItems = new List<MenuItem>(); | ||
|
|
||
| if (ButtonContainer.DownloadButton.Enabled.Value) | ||
| menuItems.Add(new OsuMenuItem(ContextMenuStrings.DownloadBeatmap, MenuItemType.Highlighted, () => ButtonContainer.DownloadButton.TriggerClick())); |
There was a problem hiding this comment.
Never said this question, but what makes menu items highlighted?
Relevant search: https://github.com/search?q=repo%3Appy%2Fosu%20MenuItemType.Highlighted&type=code
I thought the highlighting was to indicate the left-click behavior, but this makes it more inconsistent right now.
The "play" button on beatmap panels in song select was a precedent to these "view" items that I made. Other menus that don't show the left-click menu item highlight something else.
Closes #31151 I guess?
osu.2025-01-10.at.05.52.39.mp4