Add functional correctness proofs for AArch64-optimized NTT and invNTT in HOL Light #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potsrevennil
force-pushed
the
hol_light
branch
5 times, most recently
from
95845ba to
e8d9c90
Compare
potsrevennil
force-pushed
the
hol_light
branch
from
e8d9c90 to
251ca05
Compare
hanno-becker
force-pushed
the
hol_light
branch
from
251ca05 to
3b1266c
Compare
hanno-becker
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Something is still fishy in the Makefile target for object files -- see comments.
Also, the following fails:
make -j8 p256/bignum_montmul_p256.native
$S2N_BIGNUM_DIR/tools/run-proof.sh ./p256/bignum_montmul_p256.native ./p256_output
> Fatal error: exception Failure("dest_cons4: 4-byte inst code 2839547939 != first 4 bytes of []")
Could you also add a brief README that explains what one should do to fully compile + run a proof, and refer to the nix environment for setup? Is it feasible to run at least one proof in CI to confirm that the setup is functional? (e.g. a "hol-light sanity check" job or similar)
potsrevennil
force-pushed
the
hol_light
branch
2 times, most recently
from
218e722 to
0d4929c
Compare
hanno-becker
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Thank you @potsrevennil for fixing the Makefile issue.
Something is still not right, though:
make -j8 p256/bignum_montmul_p256.correct
continues to fail with
Fatal error: exception Failure("dest_cons4: 4-byte inst code 2839547939 != first 4 bytes of []")
make: *** [Makefile:440: p256/bignum_montmul_p256.correct] Error 2
81db6f5 to
a670c3e
Compare
hanno-becker
force-pushed
the
hol_light
branch
from
a670c3e to
8cbad52
Compare
potsrevennil
force-pushed
the
hol_light
branch
from
8cbad52 to
d026c4f
Compare
hanno-becker
force-pushed
the
hol_light
branch
5 times, most recently
from
a07e294 to
c486428
Compare
Signed-off-by: Thing-han, Lim <[email protected]>
The scripts in s2n_bignum assume execution within the $ROOT/<arch>/ directory and rely on relative paths. To integrate these scripts with Nix, it is necessary to adjust the paths used for loading scripts to ensure compatibility. Additionally, the Makefile located under $ROOT/<arch> has been copied to the mlkem-native directory and modified as needed to support this change. Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
hanno-becker
force-pushed
the
hol_light
branch
from
c486428 to
b8d3fdf
Compare
hanno-becker
changed the title
hanno-becker
changed the title
hanno-becker
force-pushed
the
hol_light
branch
from
b8d3fdf to
25776b6
Compare
Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
hol_light
branch
from
25776b6 to
051bc32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Steps:
s2n-bignum/arm/is copied toproofs/hol_lightand adjusted to be compatible with nix.Performed local tests:
lintpassingtests allpassingtests benchpassingtests cbmcpassingDo you expect this change to impact performance: Yes/No
If yes, please provide local benchmarking results.