Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Ferrum rather than outdated HTML to PDF generators #1370

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

practicingdev
Copy link
Contributor

I've never actually used this library myself but I've seen it consistently come up as the current HTML to PDF option that people prefer, and I believe it has no dependencies other than Chrome.

@pointlessone
Copy link
Member

Hi Greg! Any reason the other libs removed?

@practicingdev
Copy link
Contributor Author

I think it'd be fine to keep the links but I don't know who is vouching for them at this point, as those recommendations are a decade old.

It looks like the flying_saucer gem hasn't had a release in 14 years. Wicked PDF I thought was in a similar state but maybe that's wrong as I do see a 2024 update for that one. However the underlying tool it uses (wkhtmltopdf) is archived as of Jan 2023.

No major concerns here one way or the other, just realized from a convo on Bluesky how out of date this part of the README is, and wanted to drop a note calling attention to that in the form of a PR :)

@pointlessone
Copy link
Member

Yeah, sure. Just wanted some context. Thanks. Nice to see you around.

@pointlessone pointlessone merged commit aaea7f6 into prawnpdf:master Jan 7, 2025
24 of 25 checks passed
@pointlessone
Copy link
Member

I got a chuckle out of "First-time contributor" label on this PR.

@practicingdev
Copy link
Contributor Author

Well they say documentation patches are a great first time contribution to OSS so.... thank you for your prompt acceptance 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants