Skip to content

Commit

Permalink
add comments
Browse files Browse the repository at this point in the history
  • Loading branch information
JoviDeCroock committed Jul 23, 2024
1 parent cff1c1b commit e864f10
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/diff/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ function diffElementNodes(

oldProps = oldVNode.props || EMPTY_OBJ;

// TODO: do we want to keep this in v11?
// TODO: do we want to keep this in v11? Bigger question right now
// If we are in a situation where we are not hydrating but are using
// existing DOM we should read the existing DOM attributes to diff them
if (!isHydrating && excessDomChildren != null) {
Expand Down
1 change: 1 addition & 0 deletions test/browser/render.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1217,6 +1217,7 @@ describe('render()', () => {
}
});

// Would break if we remove the mutative render props removal
it('should remove attributes on pre-existing DOM', () => {
const div = document.createElement('div');
div.setAttribute('class', 'red');
Expand Down

0 comments on commit e864f10

Please sign in to comment.