Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unmount ie11 hack #4452

Closed
wants to merge 4 commits into from

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jul 23, 2024

This removes our removeNode helper which was used to remove a specific DOM Node, this was only needed for IE11 which doesn't support Element.remove()

It looks like text-nodes aren't properly recongised when calling .remove()

Copy link

github-actions bot commented Jul 23, 2024

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-12.49ms - +5.75ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +0% (-0.12ms - +0.02ms)
    preact-local vs preact-main
  • hydrate1k: faster ✔ 0% - 5% (0.07ms - 3.92ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -4% - +1% (-0.75ms - +0.18ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +3% (-1.07ms - +2.16ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +5% (-0.03ms - +0.09ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +3% (-0.30ms - +0.73ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +4% (-0.13ms - +1.23ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - -0% (-0.01ms - -0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +2% (-0.14ms - +0.24ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.04ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local876.15ms - 884.57ms-unsure 🔍
-1% - +1%
-12.49ms - +5.75ms
preact-main875.64ms - 891.82msunsure 🔍
-1% - +1%
-5.75ms - +12.49ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local25.15ms - 25.15ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main25.15ms - 25.15msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.62ms - 16.71ms-unsure 🔍
-1% - +0%
-0.12ms - +0.02ms
preact-main16.66ms - 16.77msunsure 🔍
-0% - +1%
-0.02ms - +0.12ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.69ms - 1.69ms-unsure 🔍
-0% - -0%
-0.01ms - -0.00ms
preact-main1.69ms - 1.69msunsure 🔍
+0% - +0%
+0.00ms - +0.01ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local71.90ms - 73.17ms-faster ✔
0% - 5%
0.07ms - 3.92ms
preact-main72.71ms - 76.35msslower ❌
0% - 5%
0.07ms - 3.92ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local13.16ms - 13.49ms-unsure 🔍
-1% - +2%
-0.14ms - +0.24ms
preact-main13.17ms - 13.38msunsure 🔍
-2% - +1%
-0.24ms - +0.14ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.93ms - 17.33ms-unsure 🔍
-4% - +1%
-0.75ms - +0.18ms
preact-main16.99ms - 17.84msunsure 🔍
-1% - +4%
-0.18ms - +0.75ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.62ms - 4.62ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main4.62ms - 4.62msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local72.50ms - 74.99ms-unsure 🔍
-1% - +3%
-1.07ms - +2.16ms
preact-main72.17ms - 74.23msunsure 🔍
-3% - +1%
-2.16ms - +1.07ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.53ms - 3.56ms-unsure 🔍
-0% - +1%
-0.01ms - +0.04ms
preact-main3.51ms - 3.54msunsure 🔍
-1% - +0%
-0.04ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local27.80ms - 28.43ms-unsure 🔍
-2% - +1%
-0.67ms - +0.20ms
preact-main28.04ms - 28.65msunsure 🔍
-1% - +2%
-0.20ms - +0.67ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local31.62ms - 33.48ms-unsure 🔍
-6% - +2%
-1.92ms - +0.65ms
preact-main32.30ms - 34.07msunsure 🔍
-2% - +6%
-0.65ms - +1.92ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local23.66ms - 24.11ms-unsure 🔍
-1% - +1%
-0.33ms - +0.32ms
preact-main23.66ms - 24.12msunsure 🔍
-1% - +1%
-0.32ms - +0.33ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local29.06ms - 30.23ms-unsure 🔍
-3% - +2%
-0.99ms - +0.60ms
preact-main29.30ms - 30.39msunsure 🔍
-2% - +3%
-0.60ms - +0.99ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local20.51ms - 21.76ms-unsure 🔍
-6% - +4%
-1.25ms - +0.77ms
preact-main20.58ms - 22.17msunsure 🔍
-4% - +6%
-0.77ms - +1.25ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.89ms - 23.03ms-unsure 🔍
-4% - +3%
-0.84ms - +0.68ms
preact-main22.04ms - 23.04msunsure 🔍
-3% - +4%
-0.68ms - +0.84ms
-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.92ms - 2.01ms-unsure 🔍
-2% - +5%
-0.03ms - +0.09ms
preact-main1.89ms - 1.98msunsure 🔍
-5% - +2%
-0.09ms - +0.03ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.98ms - 0.98ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main0.98ms - 0.98msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local27.22ms - 28.09ms-unsure 🔍
-1% - +3%
-0.30ms - +0.73ms
preact-main27.16ms - 27.72msunsure 🔍
-3% - +1%
-0.73ms - +0.30ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main1.25ms - 1.25msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local35.10ms - 36.21ms-unsure 🔍
-0% - +4%
-0.13ms - +1.23ms
preact-main34.71ms - 35.50msunsure 🔍
-3% - +0%
-1.23ms - +0.13ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.55ms - 3.55ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main3.55ms - 3.55msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

Size Change: -105 B (-0.17%)

Total Size: 61.9 kB

Filename Size Change
dist/preact.js 4.7 kB -13 B (-0.28%)
dist/preact.min.js 4.73 kB -19 B (-0.4%)
dist/preact.min.module.js 4.73 kB -18 B (-0.38%)
dist/preact.min.umd.js 4.75 kB -20 B (-0.42%)
dist/preact.module.js 4.72 kB -18 B (-0.38%)
dist/preact.umd.js 4.78 kB -17 B (-0.35%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.1 kB
compat/dist/compat.module.js 4.03 kB
compat/dist/compat.umd.js 4.17 kB
debug/dist/debug.js 3.7 kB
debug/dist/debug.module.js 3.71 kB
debug/dist/debug.umd.js 3.78 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 273 B
devtools/dist/devtools.umd.js 345 B
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 981 B
jsx-runtime/dist/jsxRuntime.module.js 956 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

coveralls commented Jul 23, 2024

Coverage Status

coverage: 99.485% (-0.001%) from 99.486%
when pulling 4a700ea on remove-unmount-ie11-hack
into a1c6988 on breaking-changes.

@JoviDeCroock JoviDeCroock deleted the remove-unmount-ie11-hack branch October 4, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants