Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix path filter in PR Reporter action #4644

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Conversation

rschristian
Copy link
Member

Follow up to #4643

The action is running again but it falls over as it cannot use the branch name from the fork as a reference to compare against -- that'll only work for local branches. To fix this, we simply switch over to the SHA, should do the trick for both forks & local branches all the same.

Tests here, if anyone cares to take a look. Top 3 are a local branch (real workflow + 2 workflow_run-triggered events), 3 after that are from a fork.

@coveralls
Copy link

Coverage Status

coverage: 99.618%. remained the same
when pulling f1184bf on rschristian-patch-1
into 818eafb on main.

@rschristian rschristian merged commit 1da272c into main Jan 25, 2025
5 checks passed
@rschristian rschristian deleted the rschristian-patch-1 branch January 25, 2025 11:36
@rschristian
Copy link
Member Author

Posting this here for myself in the future: whilst it seems like an obvious improvement to copy this to the CI workflow, ensuring it filters based on the latest commit only (thereby skipping running the benches for commits that haven't changed the source JS themselves), unfortunately dorny/paths-filter does not allow configuring base & ref parameters for PRs for some reason.

That might (& hopefully will) change, but for now, this is the best we can do short of splitting off the benches too, which I don't find particularly compelling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants