fix review: fmt fixes

prebid · Jan 29, 2025 · 010e003 · 010e003
1 parent e6a10a8
commit 010e003
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 16 deletions.
diff --git a/...modules/greenbids/real/time/data/v1/GreenbidsRealTimeDataProcessedAuctionRequestHook.java b/...modules/greenbids/real/time/data/v1/GreenbidsRealTimeDataProcessedAuctionRequestHook.java
@@ -78,7 +78,7 @@ public Future<InvocationResult<AuctionRequestPayload>> call(
         final AuctionContext auctionContext = invocationContext.auctionContext();
         final BidRequest bidRequest = auctionContext.getBidRequest();
         final GreenbidsConfig greenbidsConfig = Optional.ofNullable(parseBidRequestExt(auctionContext))
-                .orElse(parseAccountConfig(invocationContext.accountConfig()));
+                .orElseGet(() -> toGreenbidsConfig(invocationContext.accountConfig()));
 
         if (greenbidsConfig == null) {
             return Future.failedFuture(
@@ -113,17 +113,9 @@ private boolean isNotEmptyObjectNode(JsonNode analytics) {
         return analytics != null && analytics.isObject() && !analytics.isEmpty();
     }
 
-    private GreenbidsConfig parseAccountConfig(ObjectNode accountConfig) {
+    private GreenbidsConfig toGreenbidsConfig(ObjectNode greenbidsConfigNode) {
         try {
-            return mapper.treeToValue(accountConfig, GreenbidsConfig.class);
-        } catch (JsonProcessingException e) {
-            throw new PreBidException(e.getMessage());
-        }
-    }
-
-    private GreenbidsConfig toGreenbidsConfig(ObjectNode adapterNode) {
-        try {
-            return mapper.treeToValue(adapterNode, GreenbidsConfig.class);
+            return mapper.treeToValue(greenbidsConfigNode, GreenbidsConfig.class);
         } catch (JsonProcessingException e) {
             return null;
         }
@@ -219,8 +211,4 @@ private ObjectNode toObjectNode(Map<String, Ortb2ImpExtResult> values) {
     public String code() {
         return CODE;
     }
-
-    public String name() {
-        return "greenbids";
-    }
 }
diff --git a/src/main/java/org/prebid/server/analytics/reporter/greenbids/GreenbidsAnalyticsReporter.java b/src/main/java/org/prebid/server/analytics/reporter/greenbids/GreenbidsAnalyticsReporter.java
@@ -122,7 +122,7 @@ public <T> Future<Void> processEvent(T event) {
         }
 
         final GreenbidsConfig greenbidsConfig = Optional.ofNullable(parseBidRequestExt(auctionContext))
-                .orElse(parseAccountConfig(auctionContext.getAccount()));
+                .orElseGet(() -> parseAccountConfig(auctionContext.getAccount()));
 
         if (greenbidsConfig == null) {
             return Future.succeededFuture();