-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consumable Adapter - Rewrite to support full ORTB from GO #2927
Conversation
src/main/java/org/prebid/server/bidder/consumable/ConsumableBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/consumable/ConsumableBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/consumable/ConsumableBidder.java
Outdated
Show resolved
Hide resolved
@SuprPhatAnon do you have anything else to add in this PR, or you are done here? |
@VeryExtraordinaryUsername This PR is complete |
Hey @SuprPhatAnon, may I ask you to resolve the conflicts? |
src/main/java/org/prebid/server/bidder/consumable/ConsumableBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/consumable/ConsumableBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/consumable/ConsumableBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/consumable/ConsumableBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/consumable/ConsumableBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/consumable/ConsumableBidder.java
Outdated
Show resolved
Hide resolved
@AntoxaAntoxic Thank you for the feedback. I can work on getting these changes made. May I ask what changed since this was previously approved and just need some conflicts resolved before? |
@SuprPhatAnon Usually a PR is required to be reviewed twice. In other words, approved by at least two people. This is default practice. |
9904ee1
to
ed8868d
Compare
@AntoxaAntoxic All changes have been made. Waiting for your approval |
src/main/java/org/prebid/server/bidder/consumable/ConsumableBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/consumable/ConsumableBidder.java
Outdated
Show resolved
Hide resolved
public ConsumableBidder(String endpointUrl, JacksonMapper mapper) { | ||
this.endpointUrl = HttpUtil.validateUrl(Objects.requireNonNull(endpointUrl)); | ||
this.endpointUrl = endpointUrl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe url validation still makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
src/main/java/org/prebid/server/bidder/consumable/ConsumableBidder.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/consumable/ConsumableBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/consumable/ConsumableBidderTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
@AntoxaAntoxic Excellent! Thanks! what is the next stop to getting this merged in |
It's a merge-freeze stage now before the next major release. |
This update was a simple rebase from the current master branch |
Is there anything else that we need to do in order for this to be merged and included in the next release? We were approved but not merged into the recent 3.0.0 release. Thank you. |
@travisbeale But this PR will be part of the upcoming 3.1 release |
#2865
Full rewrite of Adapter and to match the version in Go