Add bid adapter for Yearxero; #2948
Conversation
BogdanKosarev
changed the title
| import java.util.List; | ||
| import java.util.Objects; | ||
|
|
||
| public class YearxeroBidder implements Bidder<BidRequest> { |
There was a problem hiding this comment.
as I can judge this bidder can be implemented as an alias of the generic bidder since the logic is straightforward
so please, check the generic.yaml and find there examples of the aliases
There was a problem hiding this comment.
Yes, the logic of our adapter is straightforward right now but we planning to add some updates in future. Also, I found few adapters which are also simple but don't declared as aliases.
Is aliasing of such kind of adapters obligatory?
There was a problem hiding this comment.
I believe the reason why we have adapters that are great candidates for being aliases, but they are still not, because the "plans to add some updates in future" has never been implemented. That's why we have an ongoing task to convert them to the aliases.
Do you plan on using the adapter before adding the updates you mentioned?
There was a problem hiding this comment.
Do you plan on using the adapter before adding the updates you mentioned?
There was a problem hiding this comment.
Yes, we would like to start as soon as possible and we have a list of improvements for our bidder in our backlog for implementing. We are going to work in parallel on both sides: on adapter and bidder.
There was a problem hiding this comment.
Alright, if you have further plans on updating the bidder, let it be a separate one
|
|
||
| @AllArgsConstructor(staticName = "of") | ||
| @Value | ||
| public class ExtImpYearxero { |
There was a problem hiding this comment.
looks like this class isn't used anywhere, so it could be removed
There was a problem hiding this comment.
Yes, this class is not used directly anywhere. But I thought that we need to declare such classes for custom extensions in order to make using of our adapter more clear, am I right?
There was a problem hiding this comment.
No, it's not necessary at all while the adapter just passes through everything as-is. So in order to have the code clean, I suggest removing parts that are not used.
There was a problem hiding this comment.
Done, I removed the file.
Adding a new bid adapter for Yearxero.