Port PR from PBS-Go: New adapter: MinuteMedia #2961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be two test files Also you need to add Spring configuration file You can check examples inside other bidder commits |
|
Closed due to re-implementation inside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first contribution to this repository, so I'm starting a PR early and working in small chunks so I can get correction as I go. Let me know what I'm getting wrong! I started off by adding just the configuration files. It looks like I'll have to work on the following next:
Would love to know if I'm missing anything important there.
Issue: #2918
Go PR: https://github.com/prebid/prebid-server/pull/3399/files