Add functional tests for support testing label header #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marki1an
requested changes
Feb 14, 2024
| @@ -141,6 +142,16 @@ class PrebidServerService implements ObjectMapperWrapper { | |||
| response.as(CookieSyncResponse) | |||
| } | |||
|
|
|||
| @Step("[POST RAW] /cookie_sync with uids cookies") | |||
| RawCookieSyncResponse sendCookieSyncRequestRaw(CookieSyncRequest request, UidsCookie uidsCookie) { | |||
There was a problem hiding this comment.
Please place those methods in order overloads
| @@ -89,6 +91,8 @@ class CookieSyncSpec extends BaseSpec { | |||
| private static final Map<String, String> ACUITYADS_CONFIG = ["adapters.${ACUITYADS.value}.enabled": "true"] | |||
| private static final Map<String, String> ADKERNEL_CONFIG = ["adapters.${ADKERNEL.value}.enabled": "true"] | |||
|
|
|||
| private static final def SET_COOKIE_HEADER = 'Set-Cookie' | |||
There was a problem hiding this comment.
Please move upper to the rest constant.
| def uidsCookie = UidsCookie.defaultUidsCookie | ||
|
|
||
| and: "Save account with cookie and privacySandbox configs" | ||
| def cookieSyncConfig = new AccountCookieSyncConfig(defaultLimit: 1) |
There was a problem hiding this comment.
I hope we can remove AccountCookieSyncConfig since it doesn't affect our logic
| def accountConfig = new AccountConfig(status: AccountStatus.ACTIVE, cookieSync: cookieSyncConfig, auction: accountAuctionConfig) | ||
| def account = new Account(uuid: accountId, config: accountConfig) | ||
| accountDao.save(account) | ||
|
|
There was a problem hiding this comment.
Please remove redundant empty line
Comment on lines
+2184
to
+2185
| and: "Set up generic uids cookie" | ||
| def uidsCookie = UidsCookie.defaultUidsCookie |
There was a problem hiding this comment.
This one also can be removed
Comment on lines
2205
to
2206
| PrivacySandbox.getDefaultPrivacySandbox(true, -PBSUtils.randomNumber), | ||
| PrivacySandbox.getDefaultPrivacySandbox(true, null)] |
There was a problem hiding this comment.
Are you sure that two conditions shouldn't work?
| def uidsCookie = UidsCookie.defaultUidsCookie | ||
|
|
||
| and: "Save account with cookie and privacySandbox configs" | ||
| def cookieSyncConfig = new AccountCookieSyncConfig(defaultLimit: 1) |
There was a problem hiding this comment.
AccountCookieSyncConfig can be removed
| def accountConfig = new AccountConfig(status: AccountStatus.ACTIVE, cookieSync: cookieSyncConfig, auction: accountAuctionConfig) | ||
| def account = new Account(uuid: accountId, config: accountConfig) | ||
| accountDao.save(account) | ||
|
|
| assert response.headers[SET_COOKIE_HEADER] == getCookieDeprecationHeader(privacySandbox.cookieDeprecation.ttlSeconds) | ||
| } | ||
|
|
||
| def "PBS should set cookie deprecation header from the default account when the accountId from the request is not matched"() { |
There was a problem hiding this comment.
when default account contain privacy sandbox
Comment on lines
476
to
477
| and: "Sec-Cookie-Deprecation header" | ||
| def secCookieDeprecation = [(COOKIE_DEPRECATION_HEADER): PBSUtils.randomString] |
There was a problem hiding this comment.
Don't really need set sec-cookie-deprecation header when privacy sandbox is null or false
osulzhenko
changed the base branch from
master
to
testing-label-header-support
AntoxaAntoxic
requested changes
Feb 16, 2024
| when: "PBS processes auction request with header" | ||
| defaultPbsService.sendAuctionRequest(bidRequest, secCookieDeprecation) | ||
|
|
||
| then: "BidResponse should have device.ext.cdep from sec-cookie-deprecation header" |
There was a problem hiding this comment.
probably BidderRequest should have..., please check other places
| assert bidderRequest.device.ext.cdep == secCookieDeprecation[COOKIE_DEPRECATION_HEADER] | ||
| } | ||
|
|
||
| def "PBS should set device.ext.cdep from header when default account don't contain privacy sandbox and request account is empty"() { |
| def response = prebidServerService.sendCookieSyncRequestRaw(cookieSyncRequest, uidsCookie) | ||
|
|
||
| then: "Response should contain cookie header" | ||
| assert extractCookieParameter(response.headers[SET_COOKIE_HEADER], 'Max-Age') == TimeUnit.DAYS.toSeconds(7) as Integer |
There was a problem hiding this comment.
I do not see any test that check the whole set-cookie header value
marki1an
reviewed
Feb 17, 2024
| assert extractCookieParameter(response.headers[SET_COOKIE_HEADER], 'Max-Age') == privacySandbox.cookieDeprecation.ttlSeconds | ||
| } | ||
|
|
||
| def "PBS shouldn't set cookie deprecation header when default account don't contain privacy sandbox and request account is empty"() { |
There was a problem hiding this comment.
Just when cookie sync request doesn't contain account
AntoxaAntoxic
approved these changes
Feb 19, 2024
marki1an
approved these changes
Feb 19, 2024
SerhiiNahornyi
deleted the
functional-tests/support-testing-label-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.