-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module: WURFL device enrichment #3685
Open
andreacastello
wants to merge
12
commits into
prebid:master
Choose a base branch
from
WURFL:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3,025
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module wurfl devicedetection
Hello, @andreacastello . We discussed this PR in the PBS committee meeting and this the summary:
To unblock this PR, you will need to have a way to make this code compilable and unit testable. I see several possible options:
Until this is done, we'll be leaving this project in |
PBS-Go PR for reference: prebid/prebid-server#4158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
The module populates missing or empty fields in ortb2.device with WURFL device detection data
🧠 Rationale behind the change
The WURFL module populates missing or empty fields in ortb2.device with the following data:
make: Manufacturer of the device (e.g., "Apple", "Samsung").
model: Device model (e.g., "iPhone 14", "Galaxy S22").
os: Operating system (e.g., "iOS", "Android").
osv: Operating system version (e.g., "16.0", "12.0").
h: Screen height in pixels.
w: Screen width in pixels.
ppi: Screen pixels per inch (PPI).
pixelratio: Screen pixel density ratio.
devicetype: Device type (e.g., mobile, tablet, desktop).
Note: If these fields are already populated in the bid request, the module will not overwrite them.
Publisher-Specific Enrichment
Device enrichment is selectively enabled for publishers based on their account ID. The module identifies publishers through the following fields:
site.publisher.id
(for web environments).app.publisher.id
(for mobile app environments).dooh.publisher.id
(for digital out-of-home environments).For more info about the module build and configuration, please refer to the README.md under
extra/modules/WURFL-devicedetection
🏎 Quality check
Licensing Requirement for the WURFL Device Enrichment Module
To use the WURFL Device Enrichment Module for Prebid Server, you must have a valid license for the ScientiaMobile WURFL OnSite Java API. This API is a core dependency of the module and is responsible for performing device detection and enrichment operations by leveraging ScientiaMobile's comprehensive WURFL device database.
You can obtain the required license from ScientiaMobile’s official product page: WURFL OnSite API for Java
Maintainer contact
[email protected]