Zeta Global SSP: Make sid param required #3849

abermanov-zeta · 2024-08-08T14:04:56Z

Zeta Global SSP Adapter update: 'sid' is a required parameter.

github-actions · 2024-08-08T14:05:44Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 1887ce0

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:34:	MakeRequests		78.6%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:65:	getImpressionExt	75.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:82:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:87:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:121:	getMediaTypeForBid	100.0%
total:											(statements)		88.9%

Sonali-More-Xandr · 2024-08-13T08:21:21Z

static/bidder-info/zeta_global_ssp.yaml

@@ -1,5 +1,8 @@
-endpoint: https://ssp.disqus.com/bid/prebid-server?sid=GET_SID_FROM_ZETA
+enabled: false


Can you please help me understand why you have set enabled: false? As per the Prebid Server Documentation, if you want to disable the bidder, you need to set disabled: true

Seems like copy-pasted from somewhere. Fixed. Thank you!

Sonali-More-Xandr · 2024-08-13T10:10:51Z

static/bidder-info/zeta_global_ssp.yaml

@@ -9,12 +12,14 @@ capabilities:
    mediaTypes:
      - banner
      - video
+      - audio


Please add json tests for audio

github-actions · 2024-08-21T21:02:31Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, cf67e4d

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:34:	MakeRequests		78.6%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:65:	getImpressionExt	75.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:82:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:87:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:121:	getMediaTypeForBid	100.0%
total:											(statements)		88.9%

abermanov-zeta · 2024-09-05T14:05:36Z

@Sonali-More-Xandr @onkarvhanumante Could you please take a look again? thank you.

bsardo · 2024-09-09T15:17:56Z

With a field now being required, this is a breaking change so we should hold off on merging until the next major release so that host companies are prompted to re-review their stored requests so they can make the necessary adjustments. Tagging as 3.0.

SyntaxNode · 2024-10-29T21:54:12Z

static/bidder-info/zeta_global_ssp.yaml

 userSync:
  redirect:
-    url: https://ssp.disqus.com/redirectuser?sid=GET_SID_FROM_ZETA&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&r={{.RedirectURL}}
+    url: https://ssp.disqus.com/redirectuser?sid={{.AccountID}}&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&r={{.RedirectURL}}


AccountID is not a supported macro for user sync endpoints. The information can be optionally provided, so I'm not opposed to adding the macro - but I wouldn't expect it to always be present. How does your user sync behave when the AccountID is unknown?

@SyntaxNode In case of user sync, sid param is not critical for us and doesn't really impact the behavior. However, it would be great for us to know what publisher we do cookie sync with (for internal statistics and troubleshooting).

Hi @abermanov-zeta, as @SyntaxNode mentioned, AccountID is not a supported macro for cookie syncing at this time. If you need this, could you please open a separate PR that adds support for it? If you don't need it at this time, please remove this from your redirect URL.

If you choose to open a new PR to add support for this macro, it will obviously be a macro resolved at runtime. You'll probably want to pull the account ID from endpoints/cookie_sync.go#parseRequest similar to how other runtime macro values are extracted for privacy (see privacyMacros variable) in this function, ensure that it is passed to handleResponse which then passes it to usersync/syncer.go#GetSync where the runtime macros appear to be resolved.

@bsardo Thank you! I removed the macro from the redirect url for now. I'll open a separate PR to add support for it once I have time (hopefully, this year).

bsardo · 2024-11-04T16:26:17Z

Hi @abermanov-zeta, when you have time, please resolve conflicts.

Also, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3.
For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

# Conflicts: # go.sum

github-actions · 2024-11-05T14:44:35Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 7704f6f

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:35:	MakeRequests		78.6%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:66:	getImpressionExt	75.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:83:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:88:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:122:	getMediaTypeForBid	100.0%
total:											(statements)		88.9%

abermanov-zeta · 2024-11-05T14:53:50Z

Hi @abermanov-zeta, when you have time, please resolve conflicts.

Also, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:
import (
    "github.com/prebid/prebid-server/v3/adapters"
)
As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

@bsardo Done. Thank you.

abermanov-zeta · 2024-11-21T15:19:21Z

@bsardo @Sonali-More-Xandr @SyntaxNode @onkarvhanumante @VeronikaSolovei9 Could you please review again? Thank you!

github-actions · 2024-12-09T11:48:27Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 00591b1

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:35:	MakeRequests		78.6%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:66:	getImpressionExt	75.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:83:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:88:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:122:	getMediaTypeForBid	100.0%
total:											(statements)		88.9%

Zeta Global SSP Adapter update: 'sid' is a required parameter.

1887ce0

bsardo changed the title ~~Zeta Global SSP Adapter update: 'sid' is a required parameter.~~ Zeta Global SSP: 'sid' is a required parameter. Aug 8, 2024

bsardo changed the title ~~Zeta Global SSP: 'sid' is a required parameter.~~ Zeta Global SSP: Make sid param required Aug 8, 2024

gargcreation1992 assigned onkarvhanumante and Sonali-More-Xandr Aug 13, 2024

Sonali-More-Xandr reviewed Aug 13, 2024

View reviewed changes

Zeta SSP Adapter: fix config, audio test.

cf67e4d

bsardo added the PBS 3.0 label Sep 9, 2024

bsardo assigned VeronikaSolovei9 and bsardo and unassigned onkarvhanumante and Sonali-More-Xandr Oct 28, 2024

SyntaxNode removed the PBS 3.0 label Oct 29, 2024

SyntaxNode reviewed Oct 29, 2024

View reviewed changes

abermanov-zeta added 2 commits November 5, 2024 15:36

Merge branch 'master' into feature/zeta-global-ssp-update-param

63647c6

# Conflicts: # go.sum

Zeta SSP Adapter: use v3 packages.

7704f6f

abermanov-zeta mentioned this pull request Nov 5, 2024

Zeta Global SSP: update supported modules, media types, PBS params. prebid/prebid.github.io#5620

Open

2 tasks

abermanov-zeta mentioned this pull request Nov 21, 2024

Zeta Global SSP: Add sid parameter and audio support #3939

Open

abermanov-zeta requested review from Sonali-More-Xandr and SyntaxNode November 21, 2024 15:19

Zeta SSP Adapter: removed unsupported macro from user sync endpoint.

00591b1

bsardo added the PBS 4.0 label Dec 10, 2024

VeronikaSolovei9 approved these changes Dec 11, 2024

View reviewed changes

bsardo added the adapter label Jan 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Zeta Global SSP: Make sid param required #3849

Zeta Global SSP: Make sid param required #3849

abermanov-zeta commented Aug 8, 2024

github-actions bot commented Aug 8, 2024

Sonali-More-Xandr Aug 13, 2024 •

edited

Loading

abermanov-zeta Aug 21, 2024

Sonali-More-Xandr Aug 13, 2024

abermanov-zeta Aug 21, 2024

github-actions bot commented Aug 21, 2024

abermanov-zeta commented Sep 5, 2024

bsardo commented Sep 9, 2024

SyntaxNode Oct 29, 2024

abermanov-zeta Oct 30, 2024

bsardo Dec 6, 2024 •

edited

Loading

abermanov-zeta Dec 9, 2024

bsardo commented Nov 4, 2024

github-actions bot commented Nov 5, 2024

abermanov-zeta commented Nov 5, 2024

abermanov-zeta commented Nov 21, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024

		@@ -1,5 +1,8 @@
		endpoint: https://ssp.disqus.com/bid/prebid-server?sid=GET_SID_FROM_ZETA
		enabled: false

Zeta Global SSP: Make sid param required #3849

Are you sure you want to change the base?

Zeta Global SSP: Make sid param required #3849

Conversation

abermanov-zeta commented Aug 8, 2024

github-actions bot commented Aug 8, 2024

Code coverage summary

zeta_global_ssp

Sonali-More-Xandr Aug 13, 2024 • edited Loading

Choose a reason for hiding this comment

abermanov-zeta Aug 21, 2024

Choose a reason for hiding this comment

Sonali-More-Xandr Aug 13, 2024

Choose a reason for hiding this comment

abermanov-zeta Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 21, 2024

Code coverage summary

zeta_global_ssp

abermanov-zeta commented Sep 5, 2024

bsardo commented Sep 9, 2024

SyntaxNode Oct 29, 2024

Choose a reason for hiding this comment

abermanov-zeta Oct 30, 2024

Choose a reason for hiding this comment

bsardo Dec 6, 2024 • edited Loading

Choose a reason for hiding this comment

abermanov-zeta Dec 9, 2024

Choose a reason for hiding this comment

bsardo commented Nov 4, 2024

github-actions bot commented Nov 5, 2024

Code coverage summary

zeta_global_ssp

abermanov-zeta commented Nov 5, 2024

abermanov-zeta commented Nov 21, 2024 • edited Loading

github-actions bot commented Dec 9, 2024

Code coverage summary

zeta_global_ssp

Sonali-More-Xandr Aug 13, 2024 •

edited

Loading

bsardo Dec 6, 2024 •

edited

Loading

abermanov-zeta commented Nov 21, 2024 •

edited

Loading