New Adapter: Bidtheatre #4069

andreasgreen · 2024-11-21T15:36:08Z

Docs: prebid/prebid.github.io#5723
Prebid.js: prebid/Prebid.js#12485

github-actions · 2024-11-21T15:36:50Z

adapters/bidtheatre/bidtheatre.go

+		var bidExt openrtb_ext.ExtBid
+		err := jsonutil.Unmarshal(bid.Ext, &bidExt)
+		if err == nil && bidExt.Prebid != nil {
+			return openrtb_ext.ParseBidType(string(bidExt.Prebid.Type))


Consider this as a suggestion. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, recommends implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-11-21T15:36:58Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 3eee6c5

bidtheatre

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:29:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:46:	getMediaTypeForBid	83.3%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:60:	MakeBids		69.6%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:105:	resolveMacros		80.0%
total:										(statements)		75.6%

static/bidder-info/bidtheatre.yaml

static/bidder-params/bidtheatre.json

bsardo · 2025-01-06T16:44:57Z

@Rothalack can you please review?

bsardo · 2025-01-07T16:20:55Z

@pm-nikhil-vaidya can you please review?

pm-nikhil-vaidya · 2025-01-08T06:14:41Z

Sure @bsardo

Rothalack · 2025-01-08T19:09:11Z

I have no additional feedback for this PR. Looks good to me. You'll probably want to flip pbs support to true on the docs whenever this goes out.

adapters/bidtheatre/bidtheatre.go

adapters/bidtheatre/bidtheatre_test.go

adapters/bidtheatre/bidtheatre.go

andreasgreen · 2025-01-15T08:39:53Z

Thank you all for your feedback, we will review your comments in detail and address them shortly.

adapters/bidtheatre/bidtheatre.go

static/bidder-info/bidtheatre.yaml

static/bidder-params/bidtheatre.json

adapters/bidtheatre/bidtheatretest/supplemental/status-204.json

adapters/bidtheatre/bidtheatre.go

adapters/bidtheatre/bidtheatre_test.go

github-actions · 2025-01-20T14:07:59Z

adapters/bidtheatre/bidtheatre.go

+func getMediaTypeForBid(bid openrtb2.Bid) (openrtb_ext.BidType, error) {
+	var bidExt openrtb_ext.ExtBid
+	if err := jsonutil.Unmarshal(bid.Ext, &bidExt); err == nil && bidExt.Prebid != nil {
+		return openrtb_ext.ParseBidType(string(bidExt.Prebid.Type))


Consider this as a suggestion. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, recommends implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2025-01-20T14:08:18Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 9613e42

bidtheatre

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:29:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:45:	getMediaTypeForBid	75.0%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:56:	MakeBids		94.1%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:88:	resolveMacros		80.0%
total:										(statements)		87.9%

static/bidder-info/bidtheatre.yaml

przemkaczmarek · 2025-01-21T09:55:34Z

adapters/bidtheatre/bidtheatretest/exemplary/simple-banner.json

+      ]
+    }
+  ]
+}


what happend if we add muli-format, multi-imps ?
please add multi-format and multi-imp

The mock impression already is multi-format, you want me to add mock impression requests that's multi-imp?

adapters/bidtheatre/bidtheatre_test.go

bsardo · 2025-01-22T14:51:35Z

Hi @andreasgreen, since the review process is underway, instead of rebasing and force pushing, please push new commits when making changes or merge with master to resolve conflicts if they arise. This will expedite the process as it makes it much easier and less time consuming for reviewers since we can just check the delta. When your PR is merged, all commits will be squashed. Thanks!

andreasgreen · 2025-01-22T15:17:01Z

@bsardo , sorry, I thought you required the PR to be one-commit at all times, I will push the individual commits going forward.

bsardo · 2025-01-22T20:41:59Z

@bsardo , sorry, I thought you required the PR to be one-commit at all times, I will push the individual commits going forward.

👍 No worries!

bsardo · 2025-01-22T20:43:17Z

@andreasgreen just want to point out that you'll need to run go fmt; that is why the test suite is currently failing.

github-actions · 2025-01-24T07:56:45Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 6732075

bidtheatre

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:29:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:45:	getMediaTypeForBid	75.0%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:56:	MakeBids		94.1%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:88:	resolveMacros		80.0%
total:										(statements)		87.9%

adapters/bidtheatre/bidtheatre.go

adapters/bidtheatre/bidtheatretest/supplemental/bad_response_body.json

github-actions · 2025-01-28T13:17:14Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 992de48

bidtheatre

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:29:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:45:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:56:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:90:	resolveMacros		80.0%
total:										(statements)		94.3%

github-actions bot reviewed Nov 21, 2024

View reviewed changes

przemkaczmarek reviewed Nov 26, 2024

View reviewed changes

static/bidder-info/bidtheatre.yaml Show resolved Hide resolved

przemkaczmarek reviewed Nov 26, 2024

View reviewed changes

static/bidder-info/bidtheatre.yaml Show resolved Hide resolved

przemkaczmarek reviewed Nov 26, 2024

View reviewed changes

static/bidder-info/bidtheatre.yaml Outdated Show resolved Hide resolved

przemkaczmarek reviewed Nov 26, 2024

View reviewed changes

static/bidder-params/bidtheatre.json Outdated Show resolved Hide resolved

przemkaczmarek self-assigned this Nov 26, 2024

bsardo added the adapter label Jan 6, 2025

bsardo assigned VeronikaSolovei9 Jan 7, 2025

pm-nikhil-vaidya reviewed Jan 10, 2025

View reviewed changes

bsardo reviewed Jan 19, 2025

View reviewed changes

Bidtheatre Bidder Adapter: initial release

9613e42

andreasgreen force-pushed the master branch from 3eee6c5 to 9613e42 Compare January 20, 2025 14:07

github-actions bot reviewed Jan 20, 2025

View reviewed changes

przemkaczmarek reviewed Jan 21, 2025

View reviewed changes

static/bidder-info/bidtheatre.yaml Show resolved Hide resolved

przemkaczmarek reviewed Jan 21, 2025

View reviewed changes

adapters/bidtheatre/bidtheatre_test.go Show resolved Hide resolved

gofmt

6732075

bsardo reviewed Jan 24, 2025

View reviewed changes

adapters/bidtheatre/bidtheatre.go Outdated Show resolved Hide resolved

adapters/bidtheatre/bidtheatretest/supplemental/bad_response_body.json Outdated Show resolved Hide resolved

Don't swallow errors in MakeBids

992de48

bsardo assigned bsardo and unassigned VeronikaSolovei9 Jan 28, 2025

bsardo approved these changes Jan 28, 2025

View reviewed changes

przemkaczmarek approved these changes Feb 3, 2025

View reviewed changes

bsardo merged commit 0d8f0da into prebid:master Feb 4, 2025
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Feb 4, 2025

Port PR from PBS-Go: New Adapter: Bidtheatre prebid/prebid-server-java#3725

Open

andreasgreen mentioned this pull request Feb 5, 2025

Bidtheatre Bidder Adapter: pbs support prebid/prebid.github.io#5858

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Adapter: Bidtheatre #4069

New Adapter: Bidtheatre #4069

andreasgreen commented Nov 21, 2024

github-actions bot Nov 21, 2024

github-actions bot commented Nov 21, 2024

bsardo commented Jan 6, 2025

bsardo commented Jan 7, 2025

pm-nikhil-vaidya commented Jan 8, 2025

Rothalack commented Jan 8, 2025

andreasgreen commented Jan 15, 2025

github-actions bot Jan 20, 2025

github-actions bot commented Jan 20, 2025

przemkaczmarek Jan 21, 2025

andreasgreen Jan 22, 2025

bsardo commented Jan 22, 2025

andreasgreen commented Jan 22, 2025

bsardo commented Jan 22, 2025 •

edited

Loading

bsardo commented Jan 22, 2025

github-actions bot commented Jan 24, 2025

github-actions bot commented Jan 28, 2025

New Adapter: Bidtheatre #4069

New Adapter: Bidtheatre #4069

Conversation

andreasgreen commented Nov 21, 2024

github-actions bot Nov 21, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 21, 2024

Code coverage summary

bidtheatre

bsardo commented Jan 6, 2025

bsardo commented Jan 7, 2025

pm-nikhil-vaidya commented Jan 8, 2025

Rothalack commented Jan 8, 2025

andreasgreen commented Jan 15, 2025

github-actions bot Jan 20, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 20, 2025

Code coverage summary

bidtheatre

przemkaczmarek Jan 21, 2025

Choose a reason for hiding this comment

andreasgreen Jan 22, 2025

Choose a reason for hiding this comment

bsardo commented Jan 22, 2025

andreasgreen commented Jan 22, 2025

bsardo commented Jan 22, 2025 • edited Loading

bsardo commented Jan 22, 2025

github-actions bot commented Jan 24, 2025

Code coverage summary

bidtheatre

github-actions bot commented Jan 28, 2025

Code coverage summary

bidtheatre

bsardo commented Jan 22, 2025 •

edited

Loading