Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compass: Add user sync GPP support #4093

Merged
merged 9 commits into from
Feb 6, 2025
Merged

Compass: Add user sync GPP support #4093

merged 9 commits into from
Feb 6, 2025

Conversation

CompassSSP
Copy link
Contributor

Comment on lines +21 to +22
iframe:
url: "https://sa-cs.deliverimp.com/pbserverIframe?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&pbserverUrl={{.RedirectURL}}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a 404 when I try to use this URL:
https://sa-cs.deliverimp.com/pbserverIframe?gdpr=0&gdpr_consent=CQJkOE3QJkOE3CuAAAENCZCAAP_AAH_AAAAAG5wAQG5gbnABAbmAAA.II7Nd_X__bX9n-_7_6ft0eY1f9_r37uQzDhfNs-8F3L_W_LwX32E7NF36tq4KmR4ku1bBIQNtHMnUDUmxaolVrzHsak2cpyNKJ_JkknsZe2dYGF9Pn9lD-YKZ7_5_9_f52T_9_9_-39z3_9f___dv_-__-vjf_599n_v9fV_78_Kf9______-____________8A&us_privacy=&gpp=&gpp_sid=&pbserverUrl=http%3A%2F%2Flocalhost%3A8000%2Fsetuid%3Fbidder%3Dcompass%26gdpr%3D0%26gdpr_consent%3DCQJkOE3QJkOE3CuAAAENCZCAAP_AAH_AAAAAG5wAQG5gbnABAbmAAA.II7Nd_X__bX9n-_7_6ft0eY1f9_r37uQzDhfNs-8F3L_W_LwX32E7NF36tq4KmR4ku1bBIQNtHMnUDUmxaolVrzHsak2cpyNKJ_JkknsZe2dYGF9Pn9lD-YKZ7_5_9_f52T_9_9_-39z3_9f___dv_-__-vjf_599n_v9fV_78_Kf9______-____________8A%26gpp%3D%26gpp_sid%3D%26f%3Db%26uid%3D%5BUID%5D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsardo fixed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed iframe works with ID set in PBS cookie
Screenshot 2025-01-28 at 12 10 29 PM

Comment on lines 19 to 20
url: "https://sa-cs.deliverimp.com/pserver?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&redir={{.RedirectURL}}"
userMacro: "[UID]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a 404 for this URL as well:
https://sa-cs.deliverimp.com/pserver?gdpr=0&gdpr_consent=CQJkOE3QJkOE3CuAAAENCZCAAP_AAH_AAAAAG5wAQG5gbnABAbmAAA.II7Nd_X__bX9n-_7_6ft0eY1f9_r37uQzDhfNs-8F3L_W_LwX32E7NF36tq4KmR4ku1bBIQNtHMnUDUmxaolVrzHsak2cpyNKJ_JkknsZe2dYGF9Pn9lD-YKZ7_5_9_f52T_9_9_-39z3_9f___dv_-__-vjf_599n_v9fV_78_Kf9______-____________8A&us_privacy=&gpp=&gpp_sid=&redir=http%3A%2F%2Flocalhost%3A8000%2Fsetuid%3Fbidder%3Dcompass%26gdpr%3D0%26gdpr_consent%3DCQJkOE3QJkOE3CuAAAENCZCAAP_AAH_AAAAAG5wAQG5gbnABAbmAAA.II7Nd_X__bX9n-_7_6ft0eY1f9_r37uQzDhfNs-8F3L_W_LwX32E7NF36tq4KmR4ku1bBIQNtHMnUDUmxaolVrzHsak2cpyNKJ_JkknsZe2dYGF9Pn9lD-YKZ7_5_9_f52T_9_9_-39z3_9f___dv_-__-vjf_599n_v9fV_78_Kf9______-____________8A%26gpp%3D%26gpp_sid%3D%26f%3Di%26uid%3D%5BUID%5D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsardo corrected the url

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still get a 404 for redirect.

Copy link
Contributor Author

@CompassSSP CompassSSP Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsardo changed route from /pserver to /pbserver. Check please

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed redirect works with ID set in PBS cookie
Screenshot 2025-02-05 at 12 31 26 PM

@przemkaczmarek przemkaczmarek self-requested a review December 13, 2024 07:58
@bsardo bsardo added the adapter label Jan 6, 2025
@CompassSSP CompassSSP requested a review from bsardo January 24, 2025 13:10
@bsardo bsardo changed the title Compass: add support gpp Compass: Add user sync GPP support Feb 5, 2025
@bsardo bsardo assigned guscarreon and unassigned przemkaczmarek Feb 5, 2025
@bsardo bsardo merged commit 8b2b23e into prebid:master Feb 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants