Add codepath alerts #4141
Merged
Add codepath alerts #4141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsardo
previously approved these changes
Jan 23, 2025
guscarreon
reviewed
Jan 24, 2025
| node-version: '18' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm install axios nodemailer |
There was a problem hiding this comment.
fs and path are also listed as dependencies in .github/workflows/scripts/send-notification-on-change.js, do they need to get installed here? My javascript is a little rusty.
There was a problem hiding this comment.
Does seem to be needed as it does work over in the Java repo
There was a problem hiding this comment.
Does not seem to be needed?
There was a problem hiding this comment.
'fs' and 'path' do not need to be listed in the npm install for this to work.
|
Thanks Gus - yes, this works in the PBS-Java repo. |
bsardo
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4075
This is a port of the PR that was merged in the PBS-Java repo prebid/prebid-server-java#3645
the goal is to let bidders/modules register an email address so that when a PR is opened that affects one of their files, they're at least aware of it.