New Adapter: MadSense #4169
Open
New Adapter: MadSense #4169
+1,779
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Code coverage summaryNote:
madsenseRefer here for heat map coverage report |
|
@pm-jaydeep-mohite can you please review? |
| @@ -0,0 +1,12 @@ | |||
| endpoint: "https://ads.madsense.io/pbs" | |||
There was a problem hiding this comment.
Endpoint is reachable
curl -i --location --request POST https://ads.madsense.io/pbs
HTTP/2 200
content-length: 0
| return openrtb_ext.BidTypeBanner, nil | ||
| case openrtb2.MarkupVideo: | ||
| return openrtb_ext.BidTypeVideo, nil | ||
| default: |
There was a problem hiding this comment.
UT can be added to cover default case
adapters/madsense/madsense.go
Outdated
| bidErrors = append(bidErrors, err) | ||
| continue | ||
| } | ||
|
|
There was a problem hiding this comment.
Nitpick: Remove blank line
adapters/madsense/utils.go
Outdated
Comment on lines
4
to
10
| "fmt" | ||
| "github.com/prebid/openrtb/v20/openrtb2" | ||
| "github.com/prebid/prebid-server/v3/adapters" | ||
| "github.com/prebid/prebid-server/v3/errortypes" | ||
| "github.com/prebid/prebid-server/v3/openrtb_ext" | ||
| "github.com/prebid/prebid-server/v3/util/jsonutil" | ||
| "net/http" |
There was a problem hiding this comment.
Can be re-ordered as
`
"fmt"
"net/http"
"github.com/prebid/openrtb/v20/openrtb2"
"github.com/prebid/prebid-server/v3/adapters"
"github.com/prebid/prebid-server/v3/errortypes"
"github.com/prebid/prebid-server/v3/openrtb_ext"
"github.com/prebid/prebid-server/v3/util/jsonutil"
`
Code coverage summaryNote:
madsenseRefer here for heat map coverage report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc - prebid/prebid.github.io#5824