Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON RawMessage alias, vars to consts and fix godoc comments #4188

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Add JSON RawMessage alias, vars to consts and fix godoc comments #4188

merged 1 commit into from
Feb 5, 2025

Conversation

scr-oath
Copy link
Contributor

@scr-oath scr-oath commented Jan 31, 2025 •
edited
Loading

@bsardo bsardo self-assigned this Jan 31, 2025
guscarreon
guscarreon approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@guscarreon guscarreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo changed the title Adds RawMessage type alias, move vars to consts, and fixes some godoc comments Add JSON RawMessage alias, move vars to consts and fix godoc comments Feb 5, 2025
@bsardo bsardo changed the title Add JSON RawMessage alias, move vars to consts and fix godoc comments Add JSON RawMessage alias, vars to consts and fix godoc comments Feb 5, 2025
@bsardo bsardo merged commit 1060a06 into prebid:master Feb 5, 2025
4 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsardo bsardo bsardo approved these changes

@guscarreon guscarreon guscarreon approved these changes

Assignees

@bsardo bsardo

@guscarreon guscarreon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scr-oath @bsardo @guscarreon