Currency: Intermediate rate logic #4205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes prebid#3566 The Prebid.js currency module is able to cross convert currencies using USD (or GBP) as an intermediate. This feature is not currently implemented in PBS Go, so the following error exists: 'Unable to convert from currency NOK to desired ad server currency SEK'. In this PR we implement the cross currency conversion logic through an intermediate currency as a part of the GetRate method in the currency package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
#3566
🧠 Rationale behind the change
The Prebid.js currency module is able to cross convert currencies using USD (or GBP) as an intermediate. This feature is not currently implemented in PBS Go, so the following error exists:
Unable to convert from currency NOK to desired ad server currency SEK.In this PR we implement the cross currency conversion logic through an intermediate currency as a part of the
GetRatemethod in thecurrencypackage.Related change in PBS Java
🧪 Test plan
New functionality is covered by
TestGetRate_IntermediateConversionunit test incurrency/rates_test.go.