Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alkimi: Add imp extension support #4213

Open
wants to merge 110 commits into
base: master
Choose a base branch
from

Conversation

kalidas-alkimi
Copy link
Contributor

Added bidder extension as new feature.

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 9b60ac7

alkimi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/alkimi/alkimi.go:28:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/alkimi/alkimi.go:41:	MakeRequests		81.8%
github.com/prebid/prebid-server/v3/adapters/alkimi/alkimi.go:60:	updateImps		76.5%
github.com/prebid/prebid-server/v3/adapters/alkimi/alkimi.go:115:	buildBidderRequest	100.0%
github.com/prebid/prebid-server/v3/adapters/alkimi/alkimi.go:131:	MakeBids		96.2%
github.com/prebid/prebid-server/v3/adapters/alkimi/alkimi.go:177:	resolveMacros		100.0%
github.com/prebid/prebid-server/v3/adapters/alkimi/alkimi.go:183:	getMediaTypeForImp	100.0%
total:									(statements)		88.2%

Copy link
Contributor

@linux019 linux019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the jsonutil package to marshal/unmarshal data everywhere. PBS is in the process of removing standard json, which is slow and makes more memory allocations compared to jsonutil

@bsardo bsardo changed the title Added support for Imp extention object Alkimi: Add imp extension support Feb 18, 2025
@bsardo bsardo added the adapter label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants