Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include EIDs from user.ext.eids in 2.6 upgrade function #4226

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

patmmccann
Copy link
Contributor

@patmmccann patmmccann commented Feb 19, 2025

PR to propose we keep all the eids on 2.6 upgrade from both the 2.5 location and the 2.6 location if both exist. This may frequently happen if PBS js adapter is setting the 2.6 location and the publisher is manually writing to the 2.5 location.

@SyntaxNode
Copy link
Contributor

This needs to be an issue for the Committee to discuss. All current upgrade paths prefer the new location if present and ignore the old location, which may also be present for compatibility.

Why would a publisher send a request with a mix of both the new location and the ext? I don't understand why the publisher doesn't just choose one. At some point, the publisher needs to be responsible for sending reasonable requests to PBS and this does not seem like a reasonable scenario.

@patmmccann
Copy link
Contributor Author

patmmccann commented Feb 19, 2025

I don't understand why the publisher doesn't just choose one.

In our case we are choosing the old location but prebid server bid adapter has chosen the new location. If we set the new location, many of our other bidders are not able to see it in JS. This is related to prebid/Prebid.js#12110

Edit: that doesnt appear to be true, we're only setting in ext.eids and I can no longer identify a conflict, so this pr might be solving a hypothetical problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants