Create overtoneRtdProvider.md #5827
Open
+87
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@CKBrennan : There are some markdownlint errors, can you please fix those? |
|
Hello Loic,
Thank you for following up on this. I have updated the md file to be
similar to the structure of the example you provided. Previously I was
following the example on this page, which caused some confusion.
https://docs.prebid.org/dev-docs/add-rtd-submodule.html#step-6-wait-for-prebid-volunteers-to-review
New markdown
https://github.com/overtone-ai/prebid.github.io/blob/feature/OvertoneRtdProvider/dev-docs/modules/overtoneRtdProvider.md
Let me know if you need anything from my end for the review of this. For my
knowledge, will you also be reviewing the PR to the Prebid.js repo?
Best,
Christopher
…On Tue, Jan 28, 2025 at 9:09 AM Loic Pagny ***@***.***> wrote:
@CKBrennan <https://github.com/CKBrennan> : There are some markdownlint
errors, can you please fix those?
Here is an example of a working well structured RTD module docs file :
https://github.com/prebid/Prebid.js/blob/0c60b11c0fafd35bf0a3724cfc0e5306205de3cd/modules/1plusXRtdProvider.md
—
Reply to this email directly, view it on GitHub
<#5827 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQR6CQEJATPDKRUIBCHU7AT2M43MPAVCNFSM6AAAAABVU4YFFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJYGE3TKNBTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
muuki88
reviewed
Feb 6, 2025
|
|
||
| ## Description | ||
|
|
||
| The Overtone RTD module appends Contextual segments to the bidding object based on the Overtone taxonomy and custom metrics added by the publisher. Please contact [email protected] in order to be whitelisted for use of our API and to explore dozens of contextual signals. |
There was a problem hiding this comment.
Suggested change
| The Overtone RTD module appends Contextual segments to the bidding object based on the Overtone taxonomy and custom metrics added by the publisher. Please contact [email protected] in order to be whitelisted for use of our API and to explore dozens of contextual signals. | |
| The Overtone RTD module appends Contextual segments to the bidding object based on the Overtone taxonomy and custom metrics added by the publisher. Please contact <[email protected]> in order to be whitelisted for use of our API and to explore dozens of contextual signals. |
muuki88
reviewed
Feb 6, 2025
Comment on lines
+14
to
+15
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏷 Type of documentation
📋 Checklist
Overtone RTD Module : initial release Prebid.js#12681