Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-renderer integration example #5859

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

hogekai
Copy link

@hogekai hogekai commented Feb 5, 2025

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit d9f2004
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67a4e585692d0100087e07f7
😎 Deploy Preview https://deploy-preview-5859--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It works! Amazing 🥳

Comment on lines +42 to +43
site: 1,
test: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you can keep this test setup up and running 🫶

Copy link
Author

@hogekai hogekai Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Muki,
Thank you for your review!
From the perspective of reliability and availability, I plan to use a fake RTB endpoint using the faker library that I have been developing recently

dev-docs/examples/multi-format-example.md Outdated Show resolved Hide resolved
@muuki88 muuki88 added LGTM Needs second review If somebody else should look at the change labels Feb 6, 2025
## Example

{% capture htmlCodePrebid %}
<script src="https://cdn.michao-ssp.com/original/prebid.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave this PR open until prebid/Prebid.js#12507 is merged and it can be replaced with "not-for-prod" distribution, so you don't have to maintain this distribution

googletag.display('div-banner-native');
});
{% capture htmlCodePrebid %}
<script src="https://cdn.michao-ssp.com/original/prebid.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave this PR open until prebid/Prebid.js#12507 is merged and it can be replaced with "not-for-prod" distribution, so you don't have to maintain this distribution

examples/video/outstream/pb-ve-outstream-no-server.html Outdated Show resolved Hide resolved
<p>Prebid Outstream Video Ad</p>
</div>
{% capture htmlCodePrebid %}
<script src="https://cdn.michao-ssp.com/original/prebid.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave this PR open until prebid/Prebid.js#12507 is merged and it can be replaced with "not-for-prod" distribution, so you don't have to maintain this distribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Needs second review If somebody else should look at the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants