-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in-renderer integration example #5859
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
site: 1, | ||
test: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you can keep this test setup up and running 🫶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Muki,
Thank you for your review!
From the perspective of reliability and availability, I plan to use a fake RTB endpoint using the faker library that I have been developing recently
## Example | ||
|
||
{% capture htmlCodePrebid %} | ||
<script src="https://cdn.michao-ssp.com/original/prebid.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave this PR open until prebid/Prebid.js#12507 is merged and it can be replaced with "not-for-prod" distribution, so you don't have to maintain this distribution
googletag.display('div-banner-native'); | ||
}); | ||
{% capture htmlCodePrebid %} | ||
<script src="https://cdn.michao-ssp.com/original/prebid.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave this PR open until prebid/Prebid.js#12507 is merged and it can be replaced with "not-for-prod" distribution, so you don't have to maintain this distribution
<p>Prebid Outstream Video Ad</p> | ||
</div> | ||
{% capture htmlCodePrebid %} | ||
<script src="https://cdn.michao-ssp.com/original/prebid.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave this PR open until prebid/Prebid.js#12507 is merged and it can be replaced with "not-for-prod" distribution, so you don't have to maintain this distribution
Co-authored-by: Muki Seiler <[email protected]>
Co-authored-by: Muki Seiler <[email protected]>
🏷 Type of documentation
📋 Checklist