Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ishaan Desai <[email protected]>
  • Loading branch information
tjwsch and IshaanDesai authored Aug 12, 2024
1 parent 3c205ae commit a60996a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## latest

- Add option to only use one micro simulation object in the snapshot computation https://github.com/precice/micro-manager/pull/123
- Add option to use only one micro simulation object in the snapshot computation https://github.com/precice/micro-manager/pull/123
- Explicitly check if time window has converged using the API function `is_time_window_complete()` https://github.com/precice/micro-manager/pull/118
- Add `MicroManagerSnapshot` enabling snapshot computation and storage of microdata in HDF5 format https://github.com/precice/micro-manager/pull/101
- Make `sklearn` an optional dependency
Expand Down
2 changes: 1 addition & 1 deletion docs/snapshot_configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Parameter | Description
Parameter | Description
--- | ---
`post_processing_file_name`| Path to the post-processing Python script from the current working directory. Providing a post-processing script is optional. The script must contain a class `PostProcessing` with a method `postprocessing(sim_output)` that takes the simulation output as an argument. The method can be used to post-process the simulation output before writing it to the database.
`initialize_once` | If `True` only one micro simulation is initialized and solved for all macro inputs per rank. If `False` a new micro simulation is initialized and solved for each macro input in the parameter space. Default is `False`.
`initialize_once` | If `True`, only one micro simulation is initialized and solved for all macro inputs per rank. If `False` a new micro simulation is initialized and solved for each macro input in the parameter space. Default is `False`.

## Diagnostics

Expand Down
1 change: 1 addition & 0 deletions micro_manager/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,7 @@ def interpolate_crashed_micro_sim(self):
def create_single_sim_object(self):
"""
Check if multiple snapshots can be computed on a single micro simulation object.
Returns
-------
initialize_once : bool
Expand Down

0 comments on commit a60996a

Please sign in to comment.