-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add variant schema #10
base: main
Are you sure you want to change the base?
Conversation
Closes prefix-dev/rattler-build#295 All compilers and compiler versions are still missing. Also we need macos deployment target. Is that already incorporated into rattler-build? |
@pavelzw I don't think compilers are in any way "mandatory" - they are just another variant config value. How do you envision them to be added? |
Maybe something like this? compilers:
cpp:
name/package/???: clang
version: '12.0'
<any-key>:
... Otherwise just an entry for the most common compilers c, cpp, rust, go, go-nocgo, ... to make auto completion easier |
@pavelzw I like it – but this might need a CEP etc. I also think we could add another nesting level so that we have:
But again, we haven't actually done any thinking on it yet. Currently the compiler are as they used to be
|
Similarly for that `variant_schema.json` add, | ||
|
||
```yaml | ||
# yaml-language-server: $schema=https://raw.githubusercontent.com/prefix-dev/recipe-format/main/variant_schema.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how you guys feel about this, how about changing this to some link at prefix.dev
that is a 300 to this URL? This would allow you to use better versioning and not be bound by this specific location in the repo if you ever decide on moving/renaming these files.
add some more docs & support if conditional in zip keys
TODO: need to add inline documentation.