-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a native type manager #24179
base: master
Are you sure you want to change the base?
Add a native type manager #24179
Conversation
85c6d41
to
bfb9ee4
Compare
...-sidecar-plugin/src/main/java/com/facebook/presto/sidecar/typemanager/NativeTypeManager.java
Show resolved
Hide resolved
presto-spi/src/main/java/com/facebook/presto/spi/type/TypesProvider.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/metadata/FunctionAndTypeManager.java
Outdated
Show resolved
Hide resolved
9ae0d1c
to
fa3a49b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fa3a49b
to
cb8ea2d
Compare
cb8ea2d
to
b93cb01
Compare
New release note guidelines. Please remove the manual PR link in the following format from the release note entries for this PR.
I have updated the Release Notes Guidelines to remove the examples of manually adding the PR link. |
@steveburnett Thank you. Made the change. |
8eb2bc6
to
d5ae82c
Compare
@tdcmeehan @rschlussel This PR is now ready for review, PTAL. Thanks. |
Thanks for the release note entry! Minor change to follow the Order of sections in the Release Notes Guidelines:
|
presto-common/src/main/java/com/facebook/presto/common/type/TypeManager.java
Outdated
Show resolved
Hide resolved
...-sidecar-plugin/src/main/java/com/facebook/presto/sidecar/typemanager/NativeTypeManager.java
Outdated
Show resolved
Hide resolved
...-sidecar-plugin/src/main/java/com/facebook/presto/sidecar/typemanager/NativeTypeManager.java
Outdated
Show resolved
Hide resolved
...ar-plugin/src/main/java/com/facebook/presto/sidecar/typemanager/NativeTypeManagerConfig.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/metadata/FunctionAndTypeManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few best practices/nits.
presto-common/src/main/java/com/facebook/presto/common/type/TypeManager.java
Outdated
Show resolved
Hide resolved
...-main/src/main/java/com/facebook/presto/metadata/BuiltInTypeAndFunctionNamespaceManager.java
Show resolved
Hide resolved
...-sidecar-plugin/src/main/java/com/facebook/presto/sidecar/typemanager/NativeTypeManager.java
Show resolved
Hide resolved
...-sidecar-plugin/src/main/java/com/facebook/presto/sidecar/typemanager/NativeTypeManager.java
Outdated
Show resolved
Hide resolved
...-sidecar-plugin/src/main/java/com/facebook/presto/sidecar/typemanager/NativeTypeManager.java
Outdated
Show resolved
Hide resolved
d5ae82c
to
3940eaf
Compare
Description
With the introduction of the presto-native-execution module, Presto now has forked the execution engine into a separate process. This allows for the execution engine to be written in C++ and to be more efficient than the Java execution engine. However, this also means that the execution engine code is now entirely separate from the coordinator code, and that the types supported by the coordinator might not necessarily be supported by the execution engine.
This change adds a new native type manager which allows the types supported by the C++ engine to be known to the Java coordinator.
For more context: RFC-0003
Test Plan
Unit and end-to-end tests. More comprehensive end-to-end tests will be written in the future.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.