Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a native type manager #24179

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pdabre12
Copy link
Contributor

@pdabre12 pdabre12 commented Dec 2, 2024

Description

With the introduction of the presto-native-execution module, Presto now has forked the execution engine into a separate process. This allows for the execution engine to be written in C++ and to be more efficient than the Java execution engine. However, this also means that the execution engine code is now entirely separate from the coordinator code, and that the types supported by the coordinator might not necessarily be supported by the execution engine.

This change adds a new native type manager which allows the types supported by the C++ engine to be known to the Java coordinator.

For more context: RFC-0003

Test Plan

Unit and end-to-end tests. More comprehensive end-to-end tests will be written in the future.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General C++ changes
* Add a native type manager

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Dec 2, 2024
@prestodb-ci prestodb-ci requested review from a team, ScrapCodes and auden-woolfson and removed request for a team December 2, 2024 22:11
@pdabre12 pdabre12 force-pushed the add-native-types-manager branch 3 times, most recently from 85c6d41 to bfb9ee4 Compare December 9, 2024 19:07
@pdabre12 pdabre12 changed the title [WIP] [Do not review] [native] Add a native type manager [native] Add a native type manager Dec 9, 2024
@pdabre12 pdabre12 changed the title [native] Add a native type manager Add a native type manager Dec 9, 2024
@pdabre12 pdabre12 marked this pull request as ready for review December 9, 2024 22:02
@pdabre12 pdabre12 requested a review from presto-oss December 9, 2024 22:02
@pdabre12 pdabre12 force-pushed the add-native-types-manager branch 2 times, most recently from 9ae0d1c to fa3a49b Compare December 10, 2024 20:26
Copy link
Contributor

@auden-woolfson auden-woolfson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdabre12 pdabre12 requested a review from tdcmeehan December 10, 2024 20:49
@pdabre12 pdabre12 force-pushed the add-native-types-manager branch from fa3a49b to cb8ea2d Compare December 10, 2024 22:54
@tdcmeehan tdcmeehan self-assigned this Jan 31, 2025
@pdabre12 pdabre12 force-pushed the add-native-types-manager branch from cb8ea2d to b93cb01 Compare February 4, 2025 22:41
@steveburnett
Copy link
Contributor

New release note guidelines. Please remove the manual PR link in the following format from the release note entries for this PR.


:pr:`12345`

I have updated the Release Notes Guidelines to remove the examples of manually adding the PR link.

@pdabre12
Copy link
Contributor Author

pdabre12 commented Feb 4, 2025

@steveburnett Thank you. Made the change.

@pdabre12 pdabre12 force-pushed the add-native-types-manager branch 3 times, most recently from 8eb2bc6 to d5ae82c Compare February 5, 2025 23:38
@pdabre12
Copy link
Contributor Author

pdabre12 commented Feb 6, 2025

@tdcmeehan @rschlussel This PR is now ready for review, PTAL. Thanks.

@pdabre12 pdabre12 requested a review from rschlussel February 6, 2025 19:23
@steveburnett
Copy link
Contributor

steveburnett commented Feb 6, 2025

Thanks for the release note entry! Minor change to follow the Order of sections in the Release Notes Guidelines:

== RELEASE NOTES ==

Prestissimo (Native Execution) Changes
* Add a native type manager

Copy link
Contributor

@auden-woolfson auden-woolfson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few best practices/nits.

@pdabre12 pdabre12 force-pushed the add-native-types-manager branch from d5ae82c to 3940eaf Compare February 7, 2025 22:07
@pdabre12 pdabre12 requested a review from tdcmeehan February 8, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants