-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add caching to storage partition loader and create benchmark #24345
Draft
auden-woolfson
wants to merge
25
commits into
prestodb:master
Choose a base branch
from
auden-woolfson:oss_fix_context_switches
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add caching to storage partition loader and create benchmark #24345
auden-woolfson
wants to merge
25
commits into
prestodb:master
from
auden-woolfson:oss_fix_context_switches
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
zuyu and
BryanCutler
and removed request for
a team
January 9, 2025 19:17
@agrawalreetika could you please help with the code review? |
auden-woolfson
force-pushed
the
oss_fix_context_switches
branch
from
January 14, 2025 21:59
c74dbcb
to
b22a5bf
Compare
auden-woolfson
force-pushed
the
oss_fix_context_switches
branch
from
January 15, 2025 22:34
b22a5bf
to
0531b34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users have reported performance issues caused by frequent calls to
toJobConf
in the storage partition loader. These can be fixed with a cache.If release note is NOT required, use: