Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the Include-What-You-Use for presto_cpp/main/common/ #24359

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anandamideShakyan
Copy link
Contributor

Description

Adopt the Include-What
Propose to 1) adopt Include-What-You-Use (IWYU) for header files, and 2) link what-you-use in CMakeList.

Motivation and Context

Clean Build
Screenshot 2025-01-14 at 10 52 48 AM

Incremental Build
Screenshot 2025-01-14 at 10 53 59 AM

Separate Test Target
Screenshot 2025-01-14 at 10 54 21 AM

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

@anandamideShakyan anandamideShakyan requested a review from a team as a code owner January 14, 2025 05:26
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 14, 2025
@prestodb-ci prestodb-ci requested review from a team, bibith4 and pratyakshsharma and removed request for a team January 14, 2025 05:27
@anandamideShakyan anandamideShakyan self-assigned this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants