-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a config flag tpcds.use-varchar-type
in Presto - Java TPC-DS Connector
#24406
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the doc! Unfortunately there's a problem in RST formatting that simple tables - the way the table was initially formatted - "the first column cells cannot contain multiple lines".
See https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#tables for details.
As a result, adding a second row causes the table to build looking like this:
In a local doc build I recoded the table as a grid table (formatting in the same link above) and a new doc build looked like this:
If it helps, here's a screenshot of the grid table format I used to build the second screenshot in Visual Studio:
If you redo the table in grid table formatting like I did, it should be fine.
ad361c3
to
ef3e428
Compare
Co-authored-by: Pramod Satya <[email protected]>
ef3e428
to
f2ef87b
Compare
Thanks @steveburnett for the detailed explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull updated branch, new local doc build, looks good. Thanks!
@aditi-pandit @majetideepak Please take a look, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pdabre12 : Thanks for this code. Have a question about testing... Would it be possible to run these tests https://github.com/prestodb/presto/blob/master/presto-tpcds/src/test/java/com/facebook/presto/tpcds/TestTpcds.java with the flag turned on and off to validate the correctness of this work.
Description
Add a config flag
tpcds.use-varchar-type
in Presto - Java TPC-DS ConnectorMotivation and Context
Resolves: #24362
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.