[native] Suppress connector values from being logged #24410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
ScrapCodes and
aaneja
and removed request for
a team
|
@majetideepak FYI |
czentgr
force-pushed
the
cz_reduce_config_logging
branch
2 times, most recently
from
da84da3 to
94e24e4
Compare
majetideepak
approved these changes
Jan 23, 2025
The log contains the connector key and value pairs read from the config files. The problem is that certain key-value pairs likely contain secrets that should not be logged as this leaks credentials. We cannot filter the keys to be able to print non-secret information because there is no consistency for naming schemes of these properties and we could miss newly ones added.
czentgr
force-pushed
the
cz_reduce_config_logging
branch
from
94e24e4 to
662f7ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log contains the connector key and value pairs read from the config files. The problem is that the key-value pairs likely contain secrets that should not be logged as this leaks credentials.
instead, only the configured keys are printed without the value because we cannot determine what are keys reliably because there is not a reliable naming convention across the storage adapters.
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.